From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbcGONKA (ORCPT ); Fri, 15 Jul 2016 09:10:00 -0400 Received: from outbound-smtp03.blacknight.com ([81.17.249.16]:43470 "EHLO outbound-smtp03.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362AbcGONJ2 (ORCPT ); Fri, 15 Jul 2016 09:09:28 -0400 From: Mel Gorman To: Andrew Morton Cc: Johannes Weiner , Minchan Kim , Vlastimil Babka , Linux-MM , LKML , Mel Gorman Subject: [PATCH 1/5] mm, vmscan: make shrink_node decisions more node-centric -fix Date: Fri, 15 Jul 2016 14:09:21 +0100 Message-Id: <1468588165-12461-2-git-send-email-mgorman@techsingularity.net> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1468588165-12461-1-git-send-email-mgorman@techsingularity.net> References: <1468588165-12461-1-git-send-email-mgorman@techsingularity.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch "mm, vmscan: make shrink_node decisions more node-centric" checks whether compaction is suitable on empty nodes. This is expensive rather than wrong but is worth fixing. This is a fix to the mmotm patch mm-vmscan-make-shrink_node-decisions-more-node-centric.patch Signed-off-by: Mel Gorman --- mm/vmscan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 864a3b1e5f8b..4fdb9e419588 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2408,6 +2408,8 @@ static inline bool should_continue_reclaim(struct pglist_data *pgdat, /* If compaction would go ahead or the allocation would succeed, stop */ for (z = 0; z <= sc->reclaim_idx; z++) { struct zone *zone = &pgdat->node_zones[z]; + if (!populated_zone(zone)) + continue; switch (compaction_suitable(zone, sc->order, 0, sc->reclaim_idx)) { case COMPACT_PARTIAL: -- 2.6.4