From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbcGONJz (ORCPT ); Fri, 15 Jul 2016 09:09:55 -0400 Received: from outbound-smtp06.blacknight.com ([81.17.249.39]:52767 "EHLO outbound-smtp06.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbcGONJ3 (ORCPT ); Fri, 15 Jul 2016 09:09:29 -0400 From: Mel Gorman To: Andrew Morton Cc: Johannes Weiner , Minchan Kim , Vlastimil Babka , Linux-MM , LKML , Mel Gorman Subject: [PATCH 2/5] mm, vmscan: avoid passing in classzone_idx unnecessarily to compaction_ready -fix Date: Fri, 15 Jul 2016 14:09:22 +0100 Message-Id: <1468588165-12461-3-git-send-email-mgorman@techsingularity.net> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1468588165-12461-1-git-send-email-mgorman@techsingularity.net> References: <1468588165-12461-1-git-send-email-mgorman@techsingularity.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As pointed out by Vlastimil, there is a redundant check in shrink_zones since commit "mm, vmscan: avoid passing in classzone_idx unnecessarily to compaction_ready". The zonelist iterator only returns zones that already meet the requirements of the allocation request. This is a fix to the mmotm patch mm-vmscan-avoid-passing-in-classzone_idx-unnecessarily-to-compaction_ready.patch Signed-off-by: Mel Gorman --- mm/vmscan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 4fdb9e419588..c2ad4263f965 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2606,7 +2606,6 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc) */ if (IS_ENABLED(CONFIG_COMPACTION) && sc->order > PAGE_ALLOC_COSTLY_ORDER && - zonelist_zone_idx(z) <= sc->reclaim_idx && compaction_ready(zone, sc)) { sc->compaction_ready = true; continue; -- 2.6.4