From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
linux-media@vger.kernel.org
Subject: Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling
Date: Fri, 15 Jul 2016 12:53:28 -0400 [thread overview]
Message-ID: <1468601608.3819.4.camel@ndufresne.ca> (raw)
In-Reply-To: <5718D3DC.20004@osg.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
Le jeudi 21 avril 2016 à 09:21 -0400, Javier Martinez Canillas a
écrit :
> Hello Sylwester,
>
> On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote:
> > The same struct device_node * is used for looking up the I2C
> > sensor, OF
> > graph endpoint and port. So the reference count is incremented but
> > not
> > decremented for the endpoint and port nodes.
> >
> > Fix this by having separate pointers for each node looked up.
> >
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >
>
> Any comments about this patch?
Tested-by: Nicolas Dufresne <nicoas.dufresne@collabora.com>
Note: I could not verify that leak is gone, but I could verify that
this driver is still working properly after the change.
>
> Best regards,
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-07-15 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 0:41 [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling Javier Martinez Canillas
2016-04-21 13:21 ` Javier Martinez Canillas
2016-07-15 16:53 ` Nicolas Dufresne [this message]
2016-07-15 17:05 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468601608.3819.4.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=afaerber@suse.de \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox