Re: [PATCH] checkpatch: don't complain about BIT macro in uapi

[Joe Perches <joe@perches.com>]

On Sat, 2016-07-16 at 21:41 +0300, Tomas Winkler wrote:
> BIT macro cannot be exported to UAPI, so don't complain about it in
> uapi headers.

Hi Tomas, this makes sense, but could you please
indent the second line to the open parenthesis?

Assuming this is done in V2:

Acked-by: Joe Perches <joe@perches.com>

> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  scripts/checkpatch.pl | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a0e511206f24..eee57484e42f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5733,8 +5733,9 @@ sub process {
>  			}
>  		}
>  
> -# check for #defines like: 1 <<  that could be BIT(digit)
> -		if ($line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) {
> +# check for #defines like: 1 <<  that could be BIT(digit), it is not exported to uapi
> +		if ($realfile !~ m@^include/uapi/@ &&
> +			$line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) {
>  			my $ull = "";
>  			$ull = "_ULL" if (defined($1) && $1 =~ /ll/i);
>  			if (CHK("BIT_MACRO",