From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbcGPVgR (ORCPT ); Sat, 16 Jul 2016 17:36:17 -0400 Received: from smtprelay0043.hostedemail.com ([216.40.44.43]:38689 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751772AbcGPVgP (ORCPT ); Sat, 16 Jul 2016 17:36:15 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2197:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3867:3870:3871:3872:3873:3874:4321:5007:10004:10400:10848:11232:11658:11914:12043:12517:12519:12555:12740:13069:13071:13311:13357:13439:13894:14180:14181:14659:14721:21060:21080:21221:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: route59_8d8a3e47fa72f X-Filterd-Recvd-Size: 2044 Message-ID: <1468704971.1900.0.camel@perches.com> Subject: Re: [PATCH] checkpatch: don't complain about BIT macro in uapi From: Joe Perches To: Tomas Winkler , Andy Whitcroft Cc: linux-kernel@vger.kernel.org, Andrew Morton Date: Sat, 16 Jul 2016 14:36:11 -0700 In-Reply-To: <1468694486-6156-1-git-send-email-tomas.winkler@intel.com> References: <1468694486-6156-1-git-send-email-tomas.winkler@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-07-16 at 21:41 +0300, Tomas Winkler wrote: > BIT macro cannot be exported to UAPI, so don't complain about it in > uapi headers. Hi Tomas, this makes sense, but could you please indent the second line to the open parenthesis? Assuming this is done in V2: Acked-by: Joe Perches > > Signed-off-by: Tomas Winkler > --- >  scripts/checkpatch.pl | 5 +++-- >  1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index a0e511206f24..eee57484e42f 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -5733,8 +5733,9 @@ sub process { >   } >   } >   > -# check for #defines like: 1 << that could be BIT(digit) > - if ($line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) { > +# check for #defines like: 1 << that could be BIT(digit), it is not exported to uapi > + if ($realfile !~ m@^include/uapi/@ && > + $line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) { >   my $ull = ""; >   $ull = "_ULL" if (defined($1) && $1 =~ /ll/i); >   if (CHK("BIT_MACRO",