From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbcGROS2 (ORCPT ); Mon, 18 Jul 2016 10:18:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:39612 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbcGROSY (ORCPT ); Mon, 18 Jul 2016 10:18:24 -0400 Message-ID: <1468851242.2280.14.camel@suse.com> Subject: Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling From: Oliver Neukum To: Kristian Evensen Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Network Development Date: Mon, 18 Jul 2016 16:14:02 +0200 In-Reply-To: References: <1468844691-8222-1-git-send-email-kristian.evensen@gmail.com> <1468846886.2280.6.camel@suse.com> <1468849802.2280.11.camel@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-07-18 at 16:10 +0200, Kristian Evensen wrote: > On Mon, Jul 18, 2016 at 3:50 PM, Oliver Neukum wrote: > > No, you misunderstand me. I don't want quirks if we can avoid it. > > But if you need to do this for rndis_host and cdc_ether and maybe other > > drivers you should not be touching drivers. This belongs into the core > > ethernet code. Your code is good, but you are putting it in the wrong > > places. > > Ok, sounds good. So far, I have only seen the random MAC issue with > the three previously mentioned devices, but who knows how many else is > out there with the same error ... I don't think it should be in the > core ethernet code, at least not yet, but I agree it would make sense > to move it to for example usbnet_core(). If you agree, I can prepare a > patch for it. I don't see how it would be specific for a subsystem. If the patch is correct, it belongs into the networking core. Regards Oliver