From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbcGRWMi (ORCPT ); Mon, 18 Jul 2016 18:12:38 -0400 Received: from mga11.intel.com ([192.55.52.93]:4129 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcGRWMd (ORCPT ); Mon, 18 Jul 2016 18:12:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,386,1464678000"; d="scan'208";a="1019355268" Message-ID: <1468879951.9191.100.camel@linux.intel.com> Subject: Re: [patch] crypto: sha256-mb - cleanup a || vs | typo From: Tim Chen To: Pavel Machek , Linus Torvalds Cc: Herbert Xu , Ingo Molnar , "H. Peter Anvin" , Dan Carpenter , "David S. Miller" , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Megha Dey , "Wang, Rui Y" , Denys Vlasenko , Xiaodong Liu , Linux Crypto Mailing List , Linux Kernel Mailing List , kernel-janitors , Andrew Morton , Peter Zijlstra Date: Mon, 18 Jul 2016 15:12:31 -0700 In-Reply-To: <20160718085905.GA5701@amd> References: <20160629144242.GE22818@mwanda> <8538242a-eab7-127e-e47e-26027fee4f6d@zytor.com> <1467319339.22178.256.camel@linux.intel.com> <20160701075559.GA11902@gmail.com> <20160701092806.GA13424@gondor.apana.org.au> <20160701101329.GA3833@gmail.com> <20160708162803.GA29111@linux.intel.com> <20160708164502.GA3064@gondor.apana.org.au> <20160718085905.GA5701@amd> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-07-18 at 10:59 +0200, Pavel Machek wrote: > On Fri 2016-07-08 10:19:26, Linus Torvalds wrote: > > > > [ rare comment rant. I think I'll do this once, and then ignore the discussion ] > > > > On Fri, Jul 8, 2016 at 9:45 AM, Herbert Xu wrote: > > > > > > > > > Nack.  As I said the commenting style in the crypto API is the > > > same as the network stack.  So unless we decide to change both > > > please stick to the current style. > > Can we please get rid of the brain-damaged stupid networking comment > > syntax style, PLEASE? > Please? :-). Having different comment styles between networking and > the rest is confusing. > > And yes, this uglyness is documented for net/ and drivers/net/, but > not for crypto/, so at the very least Documentation/CodingStyle should > be updated. > > Pavel The cleanup patch has already been merged.  Thanks. Tim