* [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load()
@ 2016-07-19 12:01 Wei Yongjun
2016-07-19 18:02 ` Alexey Brodkin
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2016-07-19 12:01 UTC (permalink / raw)
To: Alexey Brodkin, David Airlie; +Cc: Wei Yongjun, dri-devel, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/gpu/drm/arc/arcpgu_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
index 0226ec0..ef1d702 100644
--- a/drivers/gpu/drm/arc/arcpgu_drv.c
+++ b/drivers/gpu/drm/arc/arcpgu_drv.c
@@ -104,10 +104,8 @@ static int arcpgu_load(struct drm_device *drm)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
arcpgu->regs = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(arcpgu->regs)) {
- dev_err(drm->dev, "Could not remap IO mem\n");
+ if (IS_ERR(arcpgu->regs))
return PTR_ERR(arcpgu->regs);
- }
dev_info(drm->dev, "arc_pgu ID: 0x%x\n",
arc_pgu_read(arcpgu, ARCPGU_REG_ID));
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load()
2016-07-19 12:01 [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Wei Yongjun
@ 2016-07-19 18:02 ` Alexey Brodkin
2016-07-19 19:39 ` Sean Paul
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Brodkin @ 2016-07-19 18:02 UTC (permalink / raw)
To: weiyj_lk@163.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
yongjun_wei@trendmicro.com.cn, airlied@linux.ie
Hi Wei Yongjun,
On Tue, 2016-07-19 at 12:01 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load()
2016-07-19 18:02 ` Alexey Brodkin
@ 2016-07-19 19:39 ` Sean Paul
0 siblings, 0 replies; 3+ messages in thread
From: Sean Paul @ 2016-07-19 19:39 UTC (permalink / raw)
To: Alexey Brodkin
Cc: weiyj_lk@163.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, yongjun_wei@trendmicro.com.cn,
airlied@linux.ie
On Tue, Jul 19, 2016 at 2:02 PM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> Hi Wei Yongjun,
>
> On Tue, 2016-07-19 at 12:01 +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
Merged to drm-misc
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-19 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-19 12:01 [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Wei Yongjun
2016-07-19 18:02 ` Alexey Brodkin
2016-07-19 19:39 ` Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox