From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752066AbcGSWjq (ORCPT ); Tue, 19 Jul 2016 18:39:46 -0400 Received: from mga09.intel.com ([134.134.136.24]:44091 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbcGSWjn (ORCPT ); Tue, 19 Jul 2016 18:39:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,391,1464678000"; d="scan'208";a="736872834" Message-ID: <1468967958.2125.2.camel@linux.intel.com> Subject: Re: [PATCH] intel_pstate: Update cpu_frequency tracepoint every time From: Srinivas Pandruvada To: "Rafael J. Wysocki" , Linux PM list Cc: Linux Kernel Mailing List Date: Tue, 19 Jul 2016 15:39:18 -0700 In-Reply-To: <3678564.0E838ntcHL@vostro.rjw.lan> References: <3678564.0E838ntcHL@vostro.rjw.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-07-19 at 15:10 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Currently, intel_pstate only updates the cpu_frequency tracepoint > if the new P-state to set is different from the current one, but > that causes powertop to report 100% idle on an 100% loaded system > sometimes. > > Prevent that from happening by updating the cpu_frequency tracepoint > every time intel_pstate_update_pstate() is called. > > Signed-off-by: Rafael J. Wysocki Acked-by: Srinivas Pandruvada - > -- >  drivers/cpufreq/intel_pstate.c |   12 ++++-------- >  1 file changed, 4 insertions(+), 8 deletions(-) > > Index: linux-pm/drivers/cpufreq/intel_pstate.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/intel_pstate.c > +++ linux-pm/drivers/cpufreq/intel_pstate.c > @@ -1134,17 +1134,12 @@ static void intel_pstate_get_min_max(str >   *min = clamp_t(int, min_perf, cpu->pstate.min_pstate, > max_perf); >  } >   > -static inline void intel_pstate_record_pstate(struct cpudata *cpu, > int pstate) > -{ > - trace_cpu_frequency(pstate * cpu->pstate.scaling, cpu->cpu); > - cpu->pstate.current_pstate = pstate; > -} > - >  static void intel_pstate_set_min_pstate(struct cpudata *cpu) >  { >   int pstate = cpu->pstate.min_pstate; >   > - intel_pstate_record_pstate(cpu, pstate); > + trace_cpu_frequency(pstate * cpu->pstate.scaling, cpu->cpu); > + cpu->pstate.current_pstate = pstate; >   /* >    * Generally, there is no guarantee that this code will > always run on >    * the CPU being updated, so force the register update to > run on the > @@ -1304,10 +1299,11 @@ static inline void intel_pstate_update_p >   >   intel_pstate_get_min_max(cpu, &min_perf, &max_perf); >   pstate = clamp_t(int, pstate, min_perf, max_perf); > + trace_cpu_frequency(pstate * cpu->pstate.scaling, cpu->cpu); >   if (pstate == cpu->pstate.current_pstate) >   return; >   > - intel_pstate_record_pstate(cpu, pstate); > + cpu->pstate.current_pstate = pstate; >   wrmsrl(MSR_IA32_PERF_CTL, pstate_funcs.get_val(cpu, > pstate)); >  } >   > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html