From: Bandan Das <bsd@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] nvmx: check for shadow vmcs check on entry
Date: Wed, 20 Jul 2016 18:25:36 -0400 [thread overview]
Message-ID: <1469053536-11130-5-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1469053536-11130-1-git-send-email-bsd@redhat.com>
vmentry should check whether the vmcs provided by
the guest hypervisor is a shadow vmcs and fail.
Also, vmptrld should check whether a shadow vmcs
is being loaded by the guest without support being present
but this check happens as part of checking the revision_id.
Signed-off-by: Bandan Das <bsd@redhat.com>
---
arch/x86/kvm/vmx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 6291143..1b6f624 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -9924,6 +9924,10 @@ static int nested_vmx_run(struct kvm_vcpu *vcpu, bool launch)
skip_emulated_instruction(vcpu);
vmcs12 = get_vmcs12(vcpu);
+ if ((vmcs12->revision_id >> 31) & 1u) {
+ nested_vmx_failInvalid(vcpu);
+ return 1;
+ }
if (enable_shadow_vmcs)
copy_shadow_to_vmcs12(vmx);
--
2.5.5
next prev parent reply other threads:[~2016-07-20 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 22:25 [PATCH 0/4] vmx: miscellaneous cleanups Bandan Das
2016-07-20 22:25 ` [PATCH 1/4] nvmx: use warn_on for buggy cases when emulating invept/invvpid Bandan Das
2016-07-21 9:13 ` Paolo Bonzini
2016-07-21 19:18 ` Bandan Das
2016-07-20 22:25 ` [PATCH 2/4] nvmx: mark ept single context invalidation as supported Bandan Das
2016-07-20 22:25 ` [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Bandan Das
2016-07-21 9:15 ` Paolo Bonzini
2016-07-21 19:21 ` Bandan Das
2016-07-20 22:25 ` Bandan Das [this message]
2016-07-21 9:16 ` [PATCH 4/4] nvmx: check for shadow vmcs check on entry Paolo Bonzini
2016-07-21 19:20 ` Bandan Das
2016-07-22 8:40 ` Paolo Bonzini
2016-07-22 15:51 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469053536-11130-5-git-send-email-bsd@redhat.com \
--to=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).