From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Andy Green <andy.green@linaro.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Mark Brown <broonie@kernel.org>, Andy Green <andy@warmcat.com>,
John Stultz <john.stultz@linaro.org>
Subject: [PATCH 3/7] k3dma: Fix "nobody cared" message seen on any error
Date: Wed, 20 Jul 2016 20:53:05 -0700 [thread overview]
Message-ID: <1469073189-9167-4-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1469073189-9167-1-git-send-email-john.stultz@linaro.org>
From: Andy Green <andy.green@linaro.org>
As it was before, as soon as the DMAC IP felt there was an error
he would return IRQ_NONE since no actual transfer had completed.
After spinning on that for 100K interrupts, Linux yanks the IRQ with
a "nobody cared" error.
This patch lets it handle the interrupt and keep the IRQ alive.
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Andy Green <andy@warmcat.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: Andy Green <andy.green@linaro.org>
[jstultz: Forward ported to mainline]
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
drivers/dma/k3dma.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
index 8dd050c..c2906a82 100644
--- a/drivers/dma/k3dma.c
+++ b/drivers/dma/k3dma.c
@@ -220,11 +220,13 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id)
writel_relaxed(err1, d->base + INT_ERR1_RAW);
writel_relaxed(err2, d->base + INT_ERR2_RAW);
- if (irq_chan) {
+ if (irq_chan)
tasklet_schedule(&d->task);
+
+ if (irq_chan || err1 || err2)
return IRQ_HANDLED;
- } else
- return IRQ_NONE;
+
+ return IRQ_NONE;
}
static int k3_dma_start_txd(struct k3_dma_chan *c)
--
1.9.1
next prev parent reply other threads:[~2016-07-21 3:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 3:53 [PATCH 0/7 v3] K3DMA fixes for HiKey HDMI audio John Stultz
2016-07-21 3:53 ` [PATCH 1/7] k3dma: Fix hisi burst clipping John Stultz
2016-07-24 7:25 ` Vinod Koul
2016-07-29 22:40 ` John Stultz
2016-08-04 13:08 ` Vinod Koul
2016-08-04 17:36 ` John Stultz
2016-08-05 3:36 ` Vinod Koul
2016-07-21 3:53 ` [PATCH 2/7] k3dma: Fix dma err offsets John Stultz
2016-07-21 3:53 ` John Stultz [this message]
2016-07-21 3:53 ` [PATCH 4/7] k3dma: Add cyclic mode for audio John Stultz
2016-07-24 7:31 ` Vinod Koul
2016-07-29 22:38 ` John Stultz
2016-07-21 3:53 ` [PATCH 5/7] k3dma: Fix memory handling with cyclic mode John Stultz
2016-07-21 3:53 ` [PATCH 6/7] k3dma: Fix occasional DMA ERR issue by using proper dma api John Stultz
2016-07-21 4:26 ` zhangfei
2016-07-21 5:22 ` John Stultz
2016-07-21 6:27 ` Andy Green
2016-07-21 10:40 ` Mark Brown
2016-07-21 13:12 ` Andy Green
2016-07-21 16:18 ` John Stultz
2016-07-21 19:57 ` Andy Green
2016-07-21 16:08 ` zhangfei
2016-07-21 3:53 ` [PATCH 7/7] Kconfig: Allow k3dma driver to be selected for more then HISI3xx platforms John Stultz
2016-07-22 6:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469073189-9167-4-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=andy.green@linaro.org \
--cc=andy@warmcat.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=jg1.han@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=vinod.koul@intel.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).