public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: herbert@gondor.apana.org.au, davem@davemloft.net,
	paul.gortmaker@windriver.com
Cc: lkp@01.org, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH] crypto: x86/glue_helper make bool
Date: Thu, 21 Jul 2016 15:13:00 -0700	[thread overview]
Message-ID: <1469139180-26863-1-git-send-email-mcgrof@kernel.org> (raw)

Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
it now detects the license is missing if you try to build the driver
as a module, log below.

Fix this by removing the module option for it via Kconfig as it
cannot be a module.

glue_helper: module license 'unspecified' taints kernel.
glue_helper: module license 'unspecified' taints kernel.
Disabling lock debugging due to kernel taint
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index a9377bef25e3..ed6abf4bbf3b 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -237,7 +237,7 @@ config CRYPTO_ABLK_HELPER
 	select CRYPTO_CRYPTD
 
 config CRYPTO_GLUE_HELPER_X86
-	tristate
+	bool
 	depends on X86
 	select CRYPTO_ALGAPI
 
-- 
2.8.4

             reply	other threads:[~2016-07-21 22:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 22:13 Luis R. Rodriguez [this message]
2016-07-21 23:01 ` [PATCH] crypto: x86/glue_helper make bool Paul Gortmaker
2016-07-21 23:06   ` Luis R. Rodriguez
2016-07-21 23:13     ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469139180-26863-1-git-send-email-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox