From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751307AbcGWRbR (ORCPT ); Sat, 23 Jul 2016 13:31:17 -0400 Received: from smtprelay0104.hostedemail.com ([216.40.44.104]:45107 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751083AbcGWRbQ (ORCPT ); Sat, 23 Jul 2016 13:31:16 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3868:3871:4321:5007:7576:9040:10004:10400:10848:11026:11232:11473:11657:11658:11783:11914:12043:12048:12438:12517:12519:12740:13069:13255:13311:13357:13439:13894:14181:14659:14721:21080:30054:30060:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:19,LUA_SUMMARY:none X-HE-Tag: water33_aae2462a9b16 X-Filterd-Recvd-Size: 1818 Message-ID: <1469295072.1900.162.camel@perches.com> Subject: Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}' From: Joe Perches To: Oleg Drokin , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger Cc: Linux Kernel Mailing List , Lustre Development List , Emoly Liu Date: Sat, 23 Jul 2016 10:31:12 -0700 In-Reply-To: <1469255832-746785-13-git-send-email-green@linuxhacker.ru> References: <1469255832-746785-1-git-send-email-green@linuxhacker.ru> <1469255832-746785-13-git-send-email-green@linuxhacker.ru> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote: > From: Emoly Liu unrelated trivial notes: > diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h b/drivers/staging/lustre/lustre/obdecho/echo_internal.h [] > @@ -33,9 +33,9 @@ >   >  /* The persistent object (i.e. actually stores stuff!) */ >  #define ECHO_PERSISTENT_OBJID    1ULL > -#define ECHO_PERSISTENT_SIZE     ((__u64)(1<<20)) > +#define ECHO_PERSISTENT_SIZE     ((__u64)(1 << 20)) This is generally an error-prone pattern as the cast is done after the shift. Perhaps better is using a specific type #define ECHO_PERSISTENT_SIZE (1ULL << 20) And lustre seems to use types with unnecessary __ prefixes.