From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbcGWSKj (ORCPT ); Sat, 23 Jul 2016 14:10:39 -0400 Received: from esgaroth.petrovitsch.at ([78.47.184.11]:2825 "EHLO esgaroth.tuxoid.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbcGWSKi (ORCPT ); Sat, 23 Jul 2016 14:10:38 -0400 X-Greylist: delayed 1749 seconds by postgrey-1.27 at vger.kernel.org; Sat, 23 Jul 2016 14:10:37 EDT Message-ID: <1469295673.14838.4.camel@sysprog.at> Subject: Re: [PATCH] mfd: arizona: Remove pointless switch case From: Bernd Petrovitsch To: Charles Keepax , lee.jones@linaro.org Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Date: Sat, 23 Jul 2016 19:41:13 +0200 In-Reply-To: <1469203133-21491-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> References: <1469203133-21491-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-DCC-URT-Metrics: esgaroth.tuxoid.at 1060; Body=4 Fuz1=4 Fuz2=4 X-Spam-Report: * 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all! On Fri, 2016-07-22 at 16:58 +0100, Charles Keepax wrote: [...] >   case IRQF_TRIGGER_RISING: >   case IRQF_TRIGGER_FALLING: >   break; > - > - case IRQ_TYPE_NONE: >   default: Don't know about the kernels coding rule in that case but personally, I use that style to explicit list all enum/#define values so that it is obvious that none was forgotten. For the compiler output, it shouldn't matter anyways ... MfG, Bernd -- mobile: +43 664 4416156 http://www.sysprog.at/ Linux Software Development, Consulting and Services