From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joel Stanley <joel.stanley@au1.ibm.com>,
Jeremy Kerr <jeremy.kerr@au1.ibm.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: kexec: device shutdown vs. remove
Date: Sun, 24 Jul 2016 23:15:26 +1000 [thread overview]
Message-ID: <1469366126.8568.258.camel@kernel.crashing.org> (raw)
In-Reply-To: <87bn1nlibx.fsf@x220.int.ebiederm.org>
On Sun, 2016-07-24 at 00:24 -0500, Eric W. Biederman wrote:
> If you are willing to do the work to merge shutdown into remove and
> simplify the drivers, perform the testing and the other state I am in
> favor of the change. I think we have had enough time to see if have two
> methods was maintainable for the driver authors.
Well, remove is going away in some drivers at least...
Also shutdown() has two different meaning between kexec and actual
machine shutdown...
Should we create a new one instead ? Something like quiesce() ? If
absent, look for remove(), if absent too, look for shutdown() ...
Or we continue doing shutdown() for now with a fallback to remove() if
shutdown is NULL (this is what I've been toying with internally).
Cheers,
ben.
next prev parent reply other threads:[~2016-07-24 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 20:51 kexec: device shutdown vs. remove Benjamin Herrenschmidt
2016-07-24 5:18 ` Guenter Roeck
2016-07-24 13:13 ` Benjamin Herrenschmidt
2016-07-24 21:36 ` Eric W. Biederman
2016-07-25 0:28 ` Benjamin Herrenschmidt
2016-07-24 5:24 ` Eric W. Biederman
2016-07-24 13:15 ` Benjamin Herrenschmidt [this message]
2016-07-24 21:35 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469366126.8568.258.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.kerr@au1.ibm.com \
--cc=joel.stanley@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox