From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbcGXNPi (ORCPT ); Sun, 24 Jul 2016 09:15:38 -0400 Received: from gate.crashing.org ([63.228.1.57]:56069 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbcGXNPi (ORCPT ); Sun, 24 Jul 2016 09:15:38 -0400 Message-ID: <1469366126.8568.258.camel@kernel.crashing.org> Subject: Re: kexec: device shutdown vs. remove From: Benjamin Herrenschmidt To: "Eric W. Biederman" Cc: "linux-kernel@vger.kernel.org" , Joel Stanley , Jeremy Kerr , Greg KH Date: Sun, 24 Jul 2016 23:15:26 +1000 In-Reply-To: <87bn1nlibx.fsf@x220.int.ebiederm.org> References: <1469307112.8568.224.camel@kernel.crashing.org> <87bn1nlibx.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-07-24 at 00:24 -0500, Eric W. Biederman wrote: > If you are willing to do the work to merge shutdown into remove and > simplify the drivers, perform the testing and the other state I am in > favor of the change.  I think we have had enough time to see if have two > methods was maintainable for the driver authors. Well, remove is going away in some drivers at least... Also shutdown() has two different meaning between kexec and actual machine shutdown... Should we create a new one instead ? Something like quiesce() ? If absent, look for remove(), if absent too, look for shutdown() ... Or we continue doing shutdown() for now with a fallback to remove() if shutdown is NULL (this is what I've been toying with internally). Cheers, ben.