From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752583AbcGYAaJ (ORCPT <rfc822;w@1wt.eu>);
	Sun, 24 Jul 2016 20:30:09 -0400
Received: from gate.crashing.org ([63.228.1.57]:49559 "EHLO gate.crashing.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752472AbcGYAaF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 24 Jul 2016 20:30:05 -0400
Message-ID: <1469406536.8568.264.camel@kernel.crashing.org>
Subject: Re: kexec: device shutdown vs. remove
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Joel Stanley <joel.stanley@au1.ibm.com>,
        Jeremy Kerr <jeremy.kerr@au1.ibm.com>,
        Greg KH <gregkh@linuxfoundation.org>
Date: Mon, 25 Jul 2016 10:28:56 +1000
In-Reply-To: <87d1m2hg5i.fsf@x220.int.ebiederm.org>
References: <1469307112.8568.224.camel@kernel.crashing.org>
	 <20160724051810.GA7663@roeck-us.net>
	 <1469365988.8568.255.camel@kernel.crashing.org>
	 <87d1m2hg5i.fsf@x220.int.ebiederm.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2016-07-24 at 16:36 -0500, Eric W. Biederman wrote:
> > A lot of drivers we care about are modular. But maybe the right
> > approach is to do something like remove() if it exist and
> shutdown() if
> > it doesn't ? Or a new callback for kexec ? quiesce() ?
> 
> Perhaps remove if shutdown does not exist.  What this really takes is
> someone to care enough to sort through this mess.

Right, I have a test patch doing just that which I'm about to start
testing internally.

Cheers,
Ben.