From: Joe Perches <joe@perches.com>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
Emoly Liu <emoly.liu@intel.com>
Subject: Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'
Date: Mon, 25 Jul 2016 18:47:47 -0700 [thread overview]
Message-ID: <1469497667.1900.203.camel@perches.com> (raw)
In-Reply-To: <974D47D2-320C-42C0-BA73-1DA12B73737F@linuxhacker.ru>
On Sat, 2016-07-23 at 14:01 -0400, Oleg Drokin wrote:
> On Jul 23, 2016, at 1:31 PM, Joe Perches wrote:
[]
> > And lustre seems to use types with unnecessary __ prefixes.
> Need to see if this file is included in userspace where the __ is needed.
Maybe it'd be good to change the top level makefile to
add -I<non-uapi_dir> and -I<uapi_dir> and then move the
various files appropriately.
And all the odd depth #include "<some..depth>/include/<file>"
could then be rationalized without regard to source file
directory layout.
$ grep -roh 'include ".*include.*"' drivers/staging/lustre/|sort|uniq -c|sort -rn
82 include "../include/obd_class.h"
82 include "../../include/linux/libcfs/libcfs.h"
66 include "../include/obd_support.h"
35 include "../include/obd.h"
32 include "../include/lustre_net.h"
32 include "../include/lustre_dlm.h"
27 include "../include/lprocfs_status.h"
26 include "../include/lustre_lite.h"
22 include "../../include/linux/lnet/lib-lnet.h"
21 include "../include/lustre_fid.h"
21 include "../include/cl_object.h"
20 include "../include/lustre/lustre_idl.h"
17 include "../include/lustre_lib.h"
13 include "../../../include/linux/libcfs/libcfs.h"
12 include "../include/lustre_log.h"
9 include "../include/obd_cksum.h"
9 include "../include/lustre_sec.h"
9 include "../include/lustre_req_layout.h"
9 include "../include/lustre_ha.h"
8 include "../include/lustre_ver.h"
8 include "../include/lustre_import.h"
8 include "../../include/linux/lnet/lnetst.h"
7 include "../include/lustre_param.h"
7 include "../include/lustre_mdc.h"
7 include "../../include/linux/lnet/lnet.h"
6 include "../include/lustre_disk.h"
6 include "../include/lustre_debug.h"
5 include "../include/lustre_kernelcomm.h"
5 include "../../include/linux/lnet/lib-types.h"
4 include "../include/lustre/lustre_user.h"
4 include "../include/lustre_intent.h"
4 include "../include/lustre_fld.h"
4 include "../include/lustre_export.h"
4 include "../include/linux/lustre_compat25.h"
4 include "../../include/linux/lnet/lib-dlc.h"
3 include "../include/lustre/ll_fiemap.h"
3 include "../include/lustre_acl.h"
3 include "../../../include/linux/lnet/lnet.h"
3 include "../../../include/linux/lnet/lib-lnet.h"
2 include "../../include/obd_support.h"
2 include "../../include/obd_class.h"
2 include "../include/lustre_mds.h"
2 include "../include/lustre_eacl.h"
2 include "../include/lu_ref.h"
2 include "../include/lu_object.h"
2 include "../../include/lprocfs_status.h"
2 include "../../include/linux/lnet/types.h"
2 include "../../../include/linux/lnet/socklnd.h"
2 include "../../include/linux/lnet/lnetctl.h"
2 include "../../include/linux/libcfs/libcfs_hash.h"
2 include "../../include/linux/libcfs/libcfs_crypto.h"
1 include "../../include/lustre_ver.h"
1 include "../../include/lustre/lustre_idl.h"
1 include "../include/lustre/lustre_errno.h"
1 include "../include/lustre_handles.h"
1 include "../../include/linux/lustre_compat25.h"
1 include "../../../include/linux/lnet/types.h"
1 include "../../include/linux/lnet/nidstr.h"
1 include "../../../include/linux/lnet/lnetctl.h"
1 include "../../include/linux/lnet/api.h"
1 include "../../../include/linux/libcfs/libcfs_crypto.h"
1 include "../include/interval_tree.h"
next prev parent reply other threads:[~2016-07-26 1:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 6:36 [PATCH 00/15] Lustre cleanups Oleg Drokin
2016-07-23 6:36 ` [PATCH 01/15] lustre: switch lnet_sock_write() to sock_sendmsg() Oleg Drokin
2016-07-23 6:36 ` [PATCH 02/15] lustre: simplify the living hell out of ksocknal_lib_recv_kiov() Oleg Drokin
2016-07-23 6:37 ` [PATCH 03/15] lustre: don't reinvent struct bio_vec Oleg Drokin
2016-07-23 6:37 ` [PATCH 04/15] ksocknal_lib_recv_iov(): recvmsg doesn't bugger iovec anymore Oleg Drokin
2016-07-23 6:37 ` [PATCH 05/15] ksocknal_lib_send_iov(): sendmsg doesn't bugger iovec Oleg Drokin
2016-07-23 6:37 ` [PATCH 06/15] ksocknal_lib_send_kiov(): " Oleg Drokin
2016-07-23 6:37 ` [PATCH 07/15] lustre: ->kss_scratch... are unused now Oleg Drokin
2016-08-15 16:55 ` Greg Kroah-Hartman
2016-07-23 6:37 ` [PATCH 08/15] lustre: constify lib-move.c stuff Oleg Drokin
2016-07-23 6:37 ` [PATCH 09/15] lustre: pass iov_iter to ->lnd_recv() Oleg Drokin
2016-07-23 6:37 ` [PATCH 10/15] lustre: introduce lnet_copy_{k,}iov2iter(), kill lnet_copy_{k,}iov2{k,}iov() Oleg Drokin
2016-07-23 6:37 ` [PATCH 11/15] staging/lustre: Always return EEXIST on mkdir for existing names Oleg Drokin
2016-07-23 6:37 ` [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}' Oleg Drokin
2016-07-23 17:31 ` Joe Perches
2016-07-23 18:01 ` Oleg Drokin
2016-07-26 1:47 ` Joe Perches [this message]
2016-07-23 6:37 ` [PATCH 13/15] staging/lustre: Fix unnecessary parentheses around variables Oleg Drokin
2016-07-23 6:37 ` [PATCH 14/15] staging/lustre: Make alignment match open parenthesis Oleg Drokin
2016-07-23 6:37 ` [PATCH 15/15] staging/lustre: Remove unused cp_error from struct cl_page Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469497667.1900.203.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=emoly.liu@intel.com \
--cc=green@linuxhacker.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox