From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754789AbcGZBrx (ORCPT ); Mon, 25 Jul 2016 21:47:53 -0400 Received: from smtprelay0106.hostedemail.com ([216.40.44.106]:41739 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752395AbcGZBrv (ORCPT ); Mon, 25 Jul 2016 21:47:51 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:4321:5007:10004:10400:10848:11026:11232:11658:11783:11914:12043:12517:12519:12740:13255:13439:13894:14659:14721:21080:30054:30060:30064:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: light82_6142caeb64d61 X-Filterd-Recvd-Size: 4821 Message-ID: <1469497667.1900.203.camel@perches.com> Subject: Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}' From: Joe Perches To: Oleg Drokin Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List , Emoly Liu Date: Mon, 25 Jul 2016 18:47:47 -0700 In-Reply-To: <974D47D2-320C-42C0-BA73-1DA12B73737F@linuxhacker.ru> References: <1469255832-746785-1-git-send-email-green@linuxhacker.ru> <1469255832-746785-13-git-send-email-green@linuxhacker.ru> <1469295072.1900.162.camel@perches.com> <974D47D2-320C-42C0-BA73-1DA12B73737F@linuxhacker.ru> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-07-23 at 14:01 -0400, Oleg Drokin wrote: > On Jul 23, 2016, at 1:31 PM, Joe Perches wrote: [] > > And lustre seems to use types with unnecessary __ prefixes. > Need to see if this file is included in userspace where the __ is needed. Maybe it'd be good to change the top level makefile to add -I and -I and then move the various files appropriately. And all the odd depth #include "/include/" could then be rationalized without regard to source file directory layout. $ grep -roh 'include ".*include.*"' drivers/staging/lustre/|sort|uniq -c|sort -rn      82 include "../include/obd_class.h"      82 include "../../include/linux/libcfs/libcfs.h"      66 include "../include/obd_support.h"      35 include "../include/obd.h"      32 include "../include/lustre_net.h"      32 include "../include/lustre_dlm.h"      27 include "../include/lprocfs_status.h"      26 include "../include/lustre_lite.h"      22 include "../../include/linux/lnet/lib-lnet.h"      21 include "../include/lustre_fid.h"      21 include "../include/cl_object.h"      20 include "../include/lustre/lustre_idl.h"      17 include "../include/lustre_lib.h"      13 include "../../../include/linux/libcfs/libcfs.h"      12 include "../include/lustre_log.h"       9 include "../include/obd_cksum.h"       9 include "../include/lustre_sec.h"       9 include "../include/lustre_req_layout.h"       9 include "../include/lustre_ha.h"       8 include "../include/lustre_ver.h"       8 include "../include/lustre_import.h"       8 include "../../include/linux/lnet/lnetst.h"       7 include "../include/lustre_param.h"       7 include "../include/lustre_mdc.h"       7 include "../../include/linux/lnet/lnet.h"       6 include "../include/lustre_disk.h"       6 include "../include/lustre_debug.h"       5 include "../include/lustre_kernelcomm.h"       5 include "../../include/linux/lnet/lib-types.h"       4 include "../include/lustre/lustre_user.h"       4 include "../include/lustre_intent.h"       4 include "../include/lustre_fld.h"       4 include "../include/lustre_export.h"       4 include "../include/linux/lustre_compat25.h"       4 include "../../include/linux/lnet/lib-dlc.h"       3 include "../include/lustre/ll_fiemap.h"       3 include "../include/lustre_acl.h"       3 include "../../../include/linux/lnet/lnet.h"       3 include "../../../include/linux/lnet/lib-lnet.h"       2 include "../../include/obd_support.h"       2 include "../../include/obd_class.h"       2 include "../include/lustre_mds.h"       2 include "../include/lustre_eacl.h"       2 include "../include/lu_ref.h"       2 include "../include/lu_object.h"       2 include "../../include/lprocfs_status.h"       2 include "../../include/linux/lnet/types.h"       2 include "../../../include/linux/lnet/socklnd.h"       2 include "../../include/linux/lnet/lnetctl.h"       2 include "../../include/linux/libcfs/libcfs_hash.h"       2 include "../../include/linux/libcfs/libcfs_crypto.h"       1 include "../../include/lustre_ver.h"       1 include "../../include/lustre/lustre_idl.h"       1 include "../include/lustre/lustre_errno.h"       1 include "../include/lustre_handles.h"       1 include "../../include/linux/lustre_compat25.h"       1 include "../../../include/linux/lnet/types.h"       1 include "../../include/linux/lnet/nidstr.h"       1 include "../../../include/linux/lnet/lnetctl.h"       1 include "../../include/linux/lnet/api.h"       1 include "../../../include/linux/libcfs/libcfs_crypto.h"       1 include "../include/interval_tree.h"