From: Lyude <cpaul@redhat.com>
To: intel-gfx@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Lyude <cpaul@redhat.com>, Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/6] Finally fix watermarks
Date: Tue, 26 Jul 2016 10:50:11 -0400 [thread overview]
Message-ID: <1469544617-20003-1-git-send-email-cpaul@redhat.com> (raw)
So unfortunately, this patch series fixes most of the underruns on Skylake, but
not all of them. Even with this patchset we're still apt to potentially hitting
underruns since we don't update the ddb allocations atomically as well yet. I'm
planning to do this eventually when I get the chance, but for now this patch
series will improve the underrun situation on Skylake dramatically.
Since the last patch series, I've brought back the patch
"Always wait for pipes to update after a flush". While this patch doesn't
entirely fix things either, it lessens the chance of hitting underruns when
enabling/disabling pipes. Since we only flush when the ddb allocations change
now, another vblank wait in there shouldn't be a huge deal.
As well I've included the SAGV patch this time, since it's required for this
patch series to work properly anyhow and it's been updated. Figured it'd be
better to put everything in one place.
Lyude (5):
drm/i915/skl: Add support for the SAGV, fix underrun hangs
drm/i915/skl: Only flush pipes when we change the ddb allocation
drm/i915/skl: Fix extra whitespace in skl_flush_wm_values()
drm/i915/skl: Update plane watermarks atomically during plane updates
drm/i915/skl: Always wait for pipes to update after a flush
Matt Roper (1):
drm/i915/gen9: Only copy WM results for changed pipes to skl_hw
drivers/gpu/drm/i915/i915_drv.h | 3 +
drivers/gpu/drm/i915/i915_reg.h | 5 +
drivers/gpu/drm/i915/intel_display.c | 5 +
drivers/gpu/drm/i915/intel_drv.h | 2 +
drivers/gpu/drm/i915/intel_pm.c | 245 +++++++++++++++++++++++++++++++----
drivers/gpu/drm/i915/intel_sprite.c | 2 +
6 files changed, 239 insertions(+), 23 deletions(-)
--
2.7.4
next reply other threads:[~2016-07-26 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 14:50 Lyude [this message]
2016-07-26 14:50 ` [PATCH v3 1/6] drm/i915/skl: Add support for the SAGV, fix underrun hangs Lyude
2016-07-26 14:58 ` Maarten Lankhorst
2016-07-26 15:17 ` Ville Syrjälä
2016-07-26 14:50 ` [PATCH v3 2/6] drm/i915/gen9: Only copy WM results for changed pipes to skl_hw Lyude
2016-07-26 14:50 ` [PATCH v3 3/6] drm/i915/skl: Only flush pipes when we change the ddb allocation Lyude
2016-07-26 14:50 ` [PATCH v3 4/6] drm/i915/skl: Fix extra whitespace in skl_flush_wm_values() Lyude
2016-07-26 14:50 ` [PATCH v3 5/6] drm/i915/skl: Update plane watermarks atomically during plane updates Lyude
2016-07-26 14:50 ` [PATCH v3 6/6] drm/i915/skl: Always wait for pipes to update after a flush Lyude
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469544617-20003-1-git-send-email-cpaul@redhat.com \
--to=cpaul@redhat.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox