Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information

Romain Izard
2016-08-29T08:22:34Z

2016-08-29 10:13 GMT+02:00 Felipe Balbi <balbi@kernel.org>:
>
> Hi,
>
> Romain Izard <romain.izard.pro@gmail.com> writes:
>> Disabling USB gadget functions configured through configfs is something
>> that can happen in normal use cases. Keep the existing log for this type
>> of event, but only as information, not as an error.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> ---
>> drivers/usb/gadget/configfs.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index 70cf3477f951..11f3a649d9e5 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>>
>> list_move_tail(&f->list, &cfg->func_list);
>> if (f->unbind) {
>> - dev_err(&gi->cdev.gadget->dev, "unbind function"
>> - " '%s'/%p\n", f->name, f);
>> + dev_info(&gi->cdev.gadget->dev,
>
> seems to me dev_dbg() is a far better alternative. We really don't need
> this on everybody's log buffer unless they really _are_ debugging some
> possible issues.

OK, I'll send a v2.

--
Romain Izard