From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161270AbcGZV0f (ORCPT ); Tue, 26 Jul 2016 17:26:35 -0400 Received: from host.buserror.net ([209.198.135.123]:43223 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161008AbcGZV0d (ORCPT ); Tue, 26 Jul 2016 17:26:33 -0400 Message-ID: <1469568378.25630.119.camel@buserror.net> From: Scott Wood To: Andrey Smirnov Cc: linuxppc-dev@lists.ozlabs.org, Kumar Gala , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Alessio Igor Bogani , Daniel Axtens , linux-kernel@vger.kernel.org Date: Tue, 26 Jul 2016 16:26:18 -0500 In-Reply-To: References: <1469507114-5788-1-git-send-email-andrew.smirnov@gmail.com> <1469507114-5788-3-git-send-email-andrew.smirnov@gmail.com> <1469519945.25630.105.camel@buserror.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 75.72.173.242 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [PATCH 3/3] powerpc: Convert fsl_rstcr_restart to a reset handler X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-07-26 at 14:22 -0700, Andrey Smirnov wrote: > On Tue, Jul 26, 2016 at 12:59 AM, Scott Wood wrote: > > > > On Mon, 2016-07-25 at 21:25 -0700, Andrey Smirnov wrote: > > > > > > Convert fsl_rstcr_restart into a function to be registered with > > > register_reset_handler() API and introduce fls_rstcr_restart_register() > > > function that can be added as an initcall that would do aforementioned > > > registration. > > > > > > Signed-off-by: Andrey Smirnov > > Is there a particular motivation for this (e.g. new handlers you plan to > > register elsewhere)? > I have a MPC8548 based board that which uses, at least for time being, > SBC8548's init code(by claiming compatibility in DT) which has an > external watchdog that implements reset functionality. The driver for > watchdog is just a generic watchdog driver and having an ability to > register custom reset handlers is very handy. > > I don't really have any motivation for fixing boards other than > SBC8548 and even that I can avoid doing by making a new custom board > file in my tree that would not populate .reset field. I can drop this > patch from the series if the code of those boards is in "don't touch > it unless absolutely have to" state. I'm not saying not to touch it -- I just wanted to understand the context. -Scott