From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755501AbcG0KES (ORCPT ); Wed, 27 Jul 2016 06:04:18 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:36998 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754820AbcG0KEC (ORCPT ); Wed, 27 Jul 2016 06:04:02 -0400 Message-ID: <1469613816.2470.50.camel@pengutronix.de> Subject: Re: [PATCH v4 4/8] drm/mediatek: add support for Mediatek SoC MT2701 From: Philipp Zabel To: YT Shen Cc: CK Hu , dri-devel@lists.freedesktop.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , David Airlie , Matthias Brugger , Mao Huang , Bibby Hsieh , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, Sascha Hauer , yingjoe.chen@mediatek.com, emil.l.velikov@gmail.com, thierry.reding@gmail.com Date: Wed, 27 Jul 2016 12:03:36 +0200 In-Reply-To: <1469529774.4678.34.camel@mtksdaap41> References: <1468577274-6178-1-git-send-email-yt.shen@mediatek.com> <1468577274-6178-5-git-send-email-yt.shen@mediatek.com> <1468997599.11841.49.camel@mtksdaap41> <1469529774.4678.34.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 26.07.2016, 18:42 +0800 schrieb YT Shen: > Hi CK, > > On Wed, 2016-07-20 at 14:53 +0800, CK Hu wrote: > > Hi, YT: > > > > Some comments inline. > > > > On Fri, 2016-07-15 at 18:07 +0800, YT Shen wrote: > > > This patch add support for the Mediatek MT2701 DISP subsystem. > > > There is only one OVL engine in MT2701. > > > > > > Signed-off-by: YT Shen > > > --- > > > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 ++++ > > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 ++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 41 +++++++++++++++++++++++++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 7 +++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 31 ++++++++++++++++++++ > > > 6 files changed, 92 insertions(+) > > > > > > > [snip...] > > > > > > > > static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > > > + { .compatible = "mediatek,mt2701-disp-ovl", .data = (void *)MTK_DISP_OVL }, > > > { .compatible = "mediatek,mt8173-disp-ovl", .data = (void *)MTK_DISP_OVL }, > > > + { .compatible = "mediatek,mt2701-disp-rdma", .data = (void *)MTK_DISP_RDMA }, > > > { .compatible = "mediatek,mt8173-disp-rdma", .data = (void *)MTK_DISP_RDMA }, > > > + { .compatible = "mediatek,mt2701-disp-wdma", .data = (void *)MTK_DISP_WDMA }, > > > > Is WDMA different from MT8173 to MT2701. If they are the same, you need > > not to add compatible of 'mediatek,mt2701-disp-wdma' because use > > 'mediatek,mt8173-disp-wdma' is enough. > Yes, the hardware has differences, so we need add new compatible > 'mt2701-disp-wdma' It would be nice if you could add a short paragraph to the patch description about what the hardware differences are (probably just changed register layout in most cases). regards Philipp