From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932350AbcG0TP2 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jul 2016 15:15:28 -0400
Received: from mx2.suse.de ([195.135.220.15]:37978 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754776AbcG0TPX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jul 2016 15:15:23 -0400
Message-ID: <1469646649.7301.0.camel@suse.com>
Subject: Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change
 ti_write_byte function arguments
From: Oliver Neukum <oneukum@suse.com>
To: Mathieu OTHACEHE <m.othacehe@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Date: Wed, 27 Jul 2016 21:10:49 +0200
In-Reply-To: <87twfbnjwj.fsf@gmail.com>
References: <87twfbnjwj.fsf@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-07-27 at 18:08 +0200, Mathieu OTHACEHE wrote:
> Hi,
> 
> > this makes me think something is wrong with the data structure.
> > We should have a be32 there, it seems to me.
> 
> You mean something like :
> 
> struct ti_write_data_bytes {
> 	u8	bAddrType;
> 	u8	bDataType;
> 	u8	bDataCounter;
> 	__be32	wBaseAddr;
> 	u8	bData[0];
> } __packed;
> 
> and,
> 
> data->wBaseAddr = cpu_to_be32(addr) ?

Yes.

	Regards
		Oliver