From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752883AbcG1IuQ (ORCPT ); Thu, 28 Jul 2016 04:50:16 -0400 Received: from mga01.intel.com ([192.55.52.88]:15868 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbcG1IuK (ORCPT ); Thu, 28 Jul 2016 04:50:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,433,1464678000"; d="scan'208";a="146780740" Message-ID: <1469695803.2367.106.camel@intel.com> Subject: Re: [RESEND PATCH] thermal: helpers: Check return value of get_temp From: Zhang Rui To: Rhyland Klein , Eduardo Valentin Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 28 Jul 2016 16:50:03 +0800 In-Reply-To: <7cf6dc8c-d914-d978-8550-440717bd9b77@nvidia.com> References: <1465232019-12441-1-git-send-email-rklein@nvidia.com> <7cf6dc8c-d914-d978-8550-440717bd9b77@nvidia.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 二, 2016-07-05 at 12:22 -0400, Rhyland Klein wrote: > On 6/6/2016 12:53 PM, Rhyland Klein wrote: > > > > Check the return value of get_temp, which can fail. If it does, > > then > > unlock and return the error code. > > > > Signed-off-by: Rhyland Klein > > --- > >  drivers/thermal/thermal_helpers.c | 4 ++++ > >  1 file changed, 4 insertions(+) > > > > diff --git a/drivers/thermal/thermal_helpers.c > > b/drivers/thermal/thermal_helpers.c > > index 5e1c160944c9..dc260749f8d6 100644 > > --- a/drivers/thermal/thermal_helpers.c > > +++ b/drivers/thermal/thermal_helpers.c > > @@ -90,6 +90,10 @@ int thermal_zone_get_temp(struct > > thermal_zone_device *tz, int *temp) > >   mutex_lock(&tz->lock); > >   > >   ret = tz->ops->get_temp(tz, temp); > > + if (!ret) { > > + mutex_unlock(&tz->lock); > > + goto exit; > > + } > >   > >   if (IS_ENABLED(CONFIG_THERMAL_EMULATION) && tz- > > >emul_temperature) { > >   for (count = 0; count < tz->trips; count++) { > > > I haven't seen any comments on this patch, has anyone had a chance to > review it yet? Patch applied, it would be merged together with the thermal reorg patches. thanks, rui