From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758748AbcG1O3N (ORCPT ); Thu, 28 Jul 2016 10:29:13 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:35043 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758650AbcG1O3J (ORCPT ); Thu, 28 Jul 2016 10:29:09 -0400 Message-ID: <1469716146.14256.1.camel@gmail.com> Subject: Re: [PATCH 1/1] ixgbevf: replace integer number with bool value From: Greg To: Zhu Yanjun Cc: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 28 Jul 2016 07:29:06 -0700 In-Reply-To: <1469626117-3669-1-git-send-email-zyjzyj2000@gmail.com> References: <1469626117-3669-1-git-send-email-zyjzyj2000@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-15.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-07-27 at 21:28 +0800, Zhu Yanjun wrote: > The variable get_mac_status is a bool variable. So a bool value is > better than an integer number. > > Signed-off-by: Zhu Yanjun Looks good to me. Reviewed-by: Greg Rose > --- > drivers/net/ethernet/intel/ixgbevf/ethtool.c | 2 +- > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c > index 508e72c..ce221d1 100644 > --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c > +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c > @@ -104,7 +104,7 @@ static int ixgbevf_get_settings(struct net_device *netdev, > ecmd->transceiver = XCVR_DUMMY1; > ecmd->port = -1; > > - hw->mac.get_link_status = 1; > + hw->mac.get_link_status = true; > hw->mac.ops.check_link(hw, &link_speed, &link_up, false); > > if (link_up) { > diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > index acc2401..a98e7c2 100644 > --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > @@ -1285,7 +1285,7 @@ static irqreturn_t ixgbevf_msix_other(int irq, void *data) > struct ixgbevf_adapter *adapter = data; > struct ixgbe_hw *hw = &adapter->hw; > > - hw->mac.get_link_status = 1; > + hw->mac.get_link_status = true; > > ixgbevf_service_event_schedule(adapter); > > @@ -2109,7 +2109,7 @@ static void ixgbevf_up_complete(struct ixgbevf_adapter *adapter) > ixgbevf_save_reset_stats(adapter); > ixgbevf_init_last_counter_stats(adapter); > > - hw->mac.get_link_status = 1; > + hw->mac.get_link_status = true; > mod_timer(&adapter->service_timer, jiffies); > } >