From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753545AbcG3UMk (ORCPT ); Sat, 30 Jul 2016 16:12:40 -0400 Received: from smtprelay0003.hostedemail.com ([216.40.44.3]:38981 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752807AbcG3UMg (ORCPT ); Sat, 30 Jul 2016 16:12:36 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2894:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3874:4321:5007:6119:10004:10400:10848:11658:11783:11914:12517:12519:12740:13069:13311:13357:13439:13894:13972:14659:14721:21080:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: roof49_504692ff82025 X-Filterd-Recvd-Size: 1616 Message-ID: <1469909550.3998.123.camel@perches.com> Subject: Re: [PATCH] KEYS: Sort out big_key initialisation From: Joe Perches To: Kirill Marinushkin , dhowells@redhat.com Cc: zer0mem@yahoo.com, gregkh@linuxfoundation.org, serge@hallyn.com, james.l.morris@oracle.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Sat, 30 Jul 2016 13:12:30 -0700 In-Reply-To: <1469909004-28618-1-git-send-email-k.marinushkin@gmail.com> References: <1469909004-28618-1-git-send-email-k.marinushkin@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-07-30 at 22:03 +0200, Kirill Marinushkin wrote: > big_key has two separate initialisation functions, one that registers the > key type and one that registers the crypto.  If the key type fails to > register, there's no problem if the crypto registers successfully because > there's no way to reach the crypto except through the key type. trivia: > diff --git a/security/keys/big_key.c b/security/keys/big_key.c [] > @@ -9,6 +9,7 @@ >   * 2 of the Licence, or (at your option) any later version. >   */ >   > +#define pr_fmt(fmt) "big_key: "fmt It's much more common to use #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt