From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbcGaWWd (ORCPT ); Sun, 31 Jul 2016 18:22:33 -0400 Received: from smtprelay0184.hostedemail.com ([216.40.44.184]:52426 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751395AbcGaWWZ (ORCPT ); Sun, 31 Jul 2016 18:22:25 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3873:3874:4321:5007:6119:7903:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12517:12519:12740:13069:13071:13311:13357:13439:13894:14180:14181:14659:14721:21060:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bird85_6c08994acfa61 X-Filterd-Recvd-Size: 1716 Message-ID: <1470003741.3998.140.camel@perches.com> Subject: Re: [PATCH v3] ARM: pxa: fix GPIO double shifts From: Joe Perches To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Sun, 31 Jul 2016 15:22:21 -0700 In-Reply-To: <87shupxy50.fsf@belgarion.home> References: <1469967435-23436-1-git-send-email-robert.jarzmik@free.fr> <1469997882.3998.136.camel@perches.com> <87shupxy50.fsf@belgarion.home> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-08-01 at 00:04 +0200, Robert Jarzmik wrote: > Joe Perches writes: [] > > These might be better without the automatic use of ret > > > > return !gpio_get_value(CORGI_GPIO_AC_IN) || > >        !gpio_get_value(CORGI_GPIO_KEY_INT) || > >        !gpio_get_value(CORGI_GPIO_WAKEUP); > Yeah, I thought about this when I made the patch. > > I supposed it was written this way so that a printk was easier to add, that's > why I didn't change the useless variable. > > I have no strong opinion about this, so if you think it's worth it I can make > the additional change. Hi Robert.  Your choice. It was one of those, 'oh, bother' type of things but  I think it's worth it for readability and consistency. cheers, Joe