From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbcHAKWS (ORCPT ); Mon, 1 Aug 2016 06:22:18 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:35194 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbcHAKWJ (ORCPT ); Mon, 1 Aug 2016 06:22:09 -0400 Message-ID: <1470046870.3025.36.camel@pengutronix.de> Subject: Re: [PATCH V3 1/5] drm/imx-ldb: Add support to drm-bridge From: Philipp Zabel To: Peter Senna Tschudin Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, linux@armlinux.org.uk, airlied@linux.ie, davem@davemloft.net, geert@linux-m68k.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mchehab@kernel.org, linux@roeck-us.net, treding@nvidia.com, architt@codeaurora.org, ykk@rock-chips.com, andrey.gusakov@cogentembedded.com, boris.brezillon@free-electrons.com, enric.balletbo@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding Date: Mon, 01 Aug 2016 12:21:10 +0200 In-Reply-To: <5d55969a1509de751dc550d9a02bd5070455f99b.1469993472.git.peter.senna@collabora.com> References: <1464626385-19253-1-git-send-email-peter.senna@collabora.com> <5d55969a1509de751dc550d9a02bd5070455f99b.1469993472.git.peter.senna@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, den 31.07.2016, 21:55 +0200 schrieb Peter Senna Tschudin: > Add support to attach a drm_bridge to imx-ldb in addition to > existing support to attach a LVDS panel. > > This patch does a simple code refactoring by moving code > from for_each_child_of_node iterator to a new function named > imx_ldb_panel_ddc(). This was necessary to allow the panel ddc > code to run only when the imx_ldb is not attached to a bridge. > > Cc: Enric Balletbo i Serra > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Fabio Estevam > Cc: David Airlie > Cc: Thierry Reding > Cc: Thierry Reding > Signed-off-by: Peter Senna Tschudin > --- > Changes from V2: > - Updated to be aplied on top of Liu Ying changes that made imx-ldb atomic. > - Tested on next-20160729. [...] > @@ -469,19 +473,28 @@ static int imx_ldb_register(struct drm_device *drm, > drm_encoder_init(drm, encoder, &imx_ldb_encoder_funcs, > DRM_MODE_ENCODER_LVDS, NULL); > > - drm_connector_helper_add(&imx_ldb_ch->connector, > - &imx_ldb_connector_helper_funcs); > - drm_connector_init(drm, &imx_ldb_ch->connector, > - &imx_ldb_connector_funcs, DRM_MODE_CONNECTOR_LVDS); > - > if (imx_ldb_ch->panel) { > + drm_connector_helper_add(&imx_ldb_ch->connector, > + &imx_ldb_connector_helper_funcs); > + drm_connector_init(drm, &imx_ldb_ch->connector, > + &imx_ldb_connector_funcs, > + DRM_MODE_CONNECTOR_LVDS); This is still not right. We want to add the connector whenever there is no bridge that brings its own, not only when there is a panel. For historical reasons, the ldb driver can also work without a panel. > ret = drm_panel_attach(imx_ldb_ch->panel, > - &imx_ldb_ch->connector); > + &imx_ldb_ch->connector); What is the purpose of this change? > if (ret) > return ret; > } > > - drm_mode_connector_attach_encoder(&imx_ldb_ch->connector, encoder); Where is this gone? > + if (imx_ldb_ch->bridge) { > + imx_ldb_ch->bridge->encoder = encoder; > + > + imx_ldb_ch->encoder.bridge = imx_ldb_ch->bridge; > + ret = drm_bridge_attach(drm, imx_ldb_ch->bridge); > + if (ret) { > + DRM_ERROR("Failed to initialize bridge with drm\n"); > + return ret; > + } > + } > > return 0; > } regards Philipp