public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tal Shorer <tal.shorer@gmail.com>
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, heikki.krogerus@linux.intel.com,
	balbi@kernel.org, Tal Shorer <tal.shorer@gmail.com>
Subject: [PATCH v2 07/10] usb: ulpi: rename operations {read|write}_dev to simply {read|write}
Date: Mon,  1 Aug 2016 21:15:55 +0300	[thread overview]
Message-ID: <1470075358-19792-8-git-send-email-tal.shorer@gmail.com> (raw)
In-Reply-To: <1470075358-19792-1-git-send-email-tal.shorer@gmail.com>

With the removal of the old {read|write} operations, we can now safely
rename the new api operations {read|write}_dev to use the shorter and
clearer names {read|write}, respectively.

Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
 drivers/usb/common/ulpi.c      | 4 ++--
 drivers/usb/dwc3/ulpi.c        | 4 ++--
 include/linux/ulpi/interface.h | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
index 43142c3..fdaed7c 100644
--- a/drivers/usb/common/ulpi.c
+++ b/drivers/usb/common/ulpi.c
@@ -21,13 +21,13 @@
 
 int ulpi_read(struct ulpi *ulpi, u8 addr)
 {
-	return ulpi->ops->read_dev(ulpi->dev.parent, addr);
+	return ulpi->ops->read(ulpi->dev.parent, addr);
 }
 EXPORT_SYMBOL_GPL(ulpi_read);
 
 int ulpi_write(struct ulpi *ulpi, u8 addr, u8 val)
 {
-	return ulpi->ops->write_dev(ulpi->dev.parent, addr, val);
+	return ulpi->ops->write(ulpi->dev.parent, addr, val);
 }
 EXPORT_SYMBOL_GPL(ulpi_write);
 
diff --git a/drivers/usb/dwc3/ulpi.c b/drivers/usb/dwc3/ulpi.c
index 94eeb7a..51ac939 100644
--- a/drivers/usb/dwc3/ulpi.c
+++ b/drivers/usb/dwc3/ulpi.c
@@ -66,8 +66,8 @@ static int dwc3_ulpi_write(struct device *dev, u8 addr, u8 val)
 }
 
 static struct ulpi_ops dwc3_ulpi_ops = {
-	.read_dev = dwc3_ulpi_read,
-	.write_dev = dwc3_ulpi_write,
+	.read = dwc3_ulpi_read,
+	.write = dwc3_ulpi_write,
 };
 
 int dwc3_ulpi_init(struct dwc3 *dwc)
diff --git a/include/linux/ulpi/interface.h b/include/linux/ulpi/interface.h
index 71f3c99..ac3cd80 100644
--- a/include/linux/ulpi/interface.h
+++ b/include/linux/ulpi/interface.h
@@ -13,8 +13,8 @@ struct ulpi;
  */
 struct ulpi_ops {
 	struct device *dev;
-	int (*read_dev)(struct device *dev, u8 addr);
-	int (*write_dev)(struct device *dev, u8 addr, u8 val);
+	int (*read)(struct device *dev, u8 addr);
+	int (*write)(struct device *dev, u8 addr, u8 val);
 };
 
 struct ulpi *ulpi_register_interface(struct device *, struct ulpi_ops *);
-- 
2.7.4

  parent reply	other threads:[~2016-08-01 18:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 18:15 [PATCH v2 00/10] usb: ulpi: remove "dev" field from struct ulpi_ops Tal Shorer
2016-08-01 18:15 ` [PATCH v2 01/10] usb: ulpi: move setting of ulpi->dev parent up in ulpi_register() Tal Shorer
2016-08-01 18:15 ` [PATCH v2 02/10] usb: ulpi: add new api functions, {read|write}_dev() Tal Shorer
2016-08-01 18:15 ` [PATCH v2 03/10] usb: ulpi: use new api functions if available Tal Shorer
2016-08-16 10:55   ` Heikki Krogerus
2016-08-01 18:15 ` [PATCH v2 04/10] usb: dwc3: ulpi: use new api Tal Shorer
2016-08-01 18:15 ` [PATCH v2 05/10] usb: ulpi: remove calls to old api callbacks Tal Shorer
2016-08-01 18:15 ` [PATCH v2 06/10] usb: ulpi: remove old api callbacks from struct ulpi_ops Tal Shorer
2016-08-16 10:55   ` Heikki Krogerus
2016-08-01 18:15 ` Tal Shorer [this message]
2016-08-01 18:15 ` [PATCH v2 08/10] usb: ulpi: remove "dev" field " Tal Shorer
2016-08-16 10:58   ` Heikki Krogerus
2016-08-01 18:15 ` [PATCH v2 09/10] usb: ulpi: make ops struct constant Tal Shorer
2016-08-01 18:15 ` [PATCH v2 10/10] usb: dwc3: ulpi: make dwc3_ulpi_ops constant Tal Shorer
2016-08-09 14:04 ` [PATCH v2 00/10] usb: ulpi: remove "dev" field from struct ulpi_ops Greg KH
2016-08-09 15:55   ` Tal Shorer
2016-08-09 16:43     ` Greg KH
2016-08-15 12:02 ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470075358-19792-8-git-send-email-tal.shorer@gmail.com \
    --to=tal.shorer@gmail.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox