From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Baole Ni <baolex.ni@intel.com>,
don.brace@microsemi.com, len.brown@intel.com, pavel@ucw.cz,
gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org
Cc: iss_storagedev@hp.com, esc.storagedev@microsemi.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
chuansheng.liu@intel.com
Subject: Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 02 Aug 2016 10:42:49 -0400 [thread overview]
Message-ID: <1470148969.2485.20.camel@HansenPartnership.com> (raw)
In-Reply-To: <20160802103914.19225-1-baolex.ni@intel.com>
On Tue, 2016-08-02 at 18:39 +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access
> permission. As we know, these numeric value for access permission
> have had the corresponding macro, and that using macro can improve
> the robustness and readability of the code, thus, I suggest replacing
> the numeric parameter with the macro.
Please stop ... can't you see that sending out over a thousand emails
with a single change in each is basically spam, especially for those of
us who got our INBOXes filled by virtue of being on the direct cc. You
don't need the thousand emails to achieve agreement over whether we
should do this, and if we decide to do it, Linus would far rather run a
simple script over the kernel as it is in an -rc state. Could you
please begin a discussion by posting the suggestion and the script.
Thanks,
James
prev parent reply other threads:[~2016-08-02 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:39 [PATCH 0082/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 12:56 ` Laurence Oberman
2016-08-02 14:42 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470148969.2485.20.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=iss_storagedev@hp.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox