From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964784AbcHBP53 (ORCPT ); Tue, 2 Aug 2016 11:57:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48170 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967696AbcHBP4l (ORCPT ); Tue, 2 Aug 2016 11:56:41 -0400 Message-ID: <1470152655.18081.1.camel@redhat.com> Subject: Re: [PATCH 0254/1285] Replace numeric parameter like 0444 with macro From: Doug Ledford To: Steve Wise , "'Steven Rostedt'" Cc: "'Baole Ni'" , swise@chelsio.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, hch@infradead.org, matanb@mellanox.com, markb@mellanox.com, jgunthorpe@obsidianresearch.com, dean.luick@intel.com Date: Tue, 02 Aug 2016 11:44:15 -0400 In-Reply-To: <00c701d1ecd1$5a4caef0$0ee60cd0$@opengridcomputing.com> References: <20160802105341.30676-1-baolex.ni@intel.com> <006201d1ecc7$f6889bd0$e399d370$@opengridcomputing.com> <20160802150832.GA26697@home.goodmis.org> <00c701d1ecd1$5a4caef0$0ee60cd0$@opengridcomputing.com> Organization: Red Hat, Inc. Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-F7DcYzqLjVAVFwXTa72X" Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 02 Aug 2016 15:44:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-F7DcYzqLjVAVFwXTa72X Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-08-02 at 10:20 -0500, Steve Wise wrote: > >=20 > >=20 > > On Tue, Aug 02, 2016 at 09:12:54AM -0500, Steve Wise wrote: > > >=20 > > > Acked-by: Steve Wise > > >=20 > >=20 > > I have to ask, why did you ack all these? There's several things > > wrong with > > this patch series, but even the point of the patch is mistaken. It > > makes > > readable code much less readable. When you chmod a file, do you > > type > >=20 > > =C2=A0 chmod 0444 file > >=20 > > or do you write > >=20 > > =C2=A0 chmod S_IRUSR|S_IRGRP|S_IROTH file > >=20 > > ? > >=20 > > Which of the above is easier to figure what is being changed? > >=20 >=20 > I assumed this was some global "fix up".=C2=A0=C2=A0=C2=A0 It is, but I'm not so sure I don't agree with Steve. =C2=A0I'm not sure thi= s actually makes things better. =C2=A0At a minimum, I would argue that Bart's fix is mandatory before they would get my ack. =C2=A0I would also request that even though the patches are split up for review, they be squashed on commit (whoever would want to tackle this monstrous pile of dubious janitorial stuff). > >=20 > > Not to mention, because the subject is the same for all 1285 > > patches, and you > > deleted the content of the patch in your ack, there's no way to > > know what > > exactly this ack is for (I haven't received the original patch yet > > because > > it's probably being ratelimited by some mail server). > >=20 >=20 > I acked just the single patches that hit cxgb3/cxgb4.=C2=A0=C2=A0But if t= his is > really > garbage, then ignore my ACKs... >=20 > Steve. >=20 --=20 Doug Ledford GPG KeyID: 0E572FDD --=-F7DcYzqLjVAVFwXTa72X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXoL/QAAoJELgmozMOVy/dj4cP/jIeTngHBfQ4EE1Bli+wjgS+ xvQaOgvUyq+CKdrxbWTbFOMUTwoMgUjCFjwoa5vb5CA25PwGRf1S5hwwMJ2f9SJe HMvHUEb4hW/J34Q/nzRLj8SIwYEJp+dxwMZS/nVMX5fX8eJdhD/e7Dg42XiLMcwu VHY18BRNO9k92ZNOtd6qHPTOYHRf2KCPXVvG5gqo1tn3RzQqhww8U5zcxDmL6L0G VxH59PAohMrB8YrtnKRr+DJ8LaHzEXyK7aitvOs242ZVEGa4HrBA55bBXRaSRYkD 4VPPtVEWD8//i1DldevkgF4aAoAt9bg9ypZtNN+BvFz8VpsIveqFoy3+TTvpJI3G pmwbrx2kqhspsdHdx709GsHkwQZJSyH3ATDPRVh4N2+adYackb0oA/5XGZWkGFsw s9tN+a1hSbawGngGJvGyVChLZHPu9sy3zjybG92aq9dUwhes9pDzn92jPRcqwaIW gOYCFjXvuoKY3i7iDOIgCfUPxty8fEtpAW0Ui5p6qRePt3VLlu2SKRkALzDt0RKu wlfbD+l1c4QJZEt8DaNlpXXgA7Yq6J5JVUeowGC7BMrz61VhDHtR+RoUBa/o3Yi3 3PkNdiaS1it5lF3qPKdaLN7izPAkiY+Ryy2ouBKuMNlpZiujLqVTFnFY+Q7chxva xbU5+j1YP4najCsHSvNK =OFZO -----END PGP SIGNATURE----- --=-F7DcYzqLjVAVFwXTa72X--