From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754832AbcHCJWu (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Aug 2016 05:22:50 -0400
Received: from mx2.suse.de ([195.135.220.15]:43896 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753191AbcHCJWp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Aug 2016 05:22:45 -0400
Message-ID: <1470215880.4612.3.camel@suse.com>
Subject: Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)
From: Oliver Neukum <oneukum@suse.com>
To: Guenter Roeck <groeck@chromium.org>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>, Bin Gao <bin.gao@intel.com>,
        Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>,
        Pranav Tipnis <pranav.tipnis@intel.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Bruce Ashfield <bruce.ashfield@windriver.com>
Date: Wed, 03 Aug 2016 11:18:00 +0200
In-Reply-To: <1470169975-19941-4-git-send-email-groeck@chromium.org>
References: <1470169975-19941-1-git-send-email-groeck@chromium.org>
	 <1470169975-19941-4-git-send-email-groeck@chromium.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
> +static int tcpm_set_polarity(struct tcpm_port *port,
> +                            enum typec_cc_polarity polarity)
> +{
> +       tcpm_log(port, "polarity %d", polarity);
> +
> +       port->polarity = polarity;
> +
> +       return port->tcpc->set_polarity(port->tcpc, port->polarity);
> +}

Here you don't care about the result.

> +
> +static int tcpm_set_vconn(struct tcpm_port *port, bool enable)
> +{
> +       int ret = 0;
> +
> +       tcpm_log(port, "vconn:=%d", enable);
> +
> +       ret = port->tcpc->set_vconn(port->tcpc, enable);
> +       if (!ret) {
> +               port->con.vconn_role = enable ? TYPEC_SOURCE
> +                                             : TYPEC_SINK;
> +               typec_set_vconn_role(port->typec_port,
> port->con.vconn_role);
> +       }
> +
> +       return ret;
> +}

But here you do. Which is right?

	Regards
		Oliver