From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756224AbcHCJer (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Aug 2016 05:34:47 -0400
Received: from mx2.suse.de ([195.135.220.15]:44325 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753042AbcHCJeo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Aug 2016 05:34:44 -0400
Message-ID: <1470216484.4612.4.camel@suse.com>
Subject: Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)
From: Oliver Neukum <oneukum@suse.com>
To: Guenter Roeck <groeck@chromium.org>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>, Bin Gao <bin.gao@intel.com>,
        Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>,
        Pranav Tipnis <pranav.tipnis@intel.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Bruce Ashfield <bruce.ashfield@windriver.com>
Date: Wed, 03 Aug 2016 11:28:04 +0200
In-Reply-To: <1470169975-19941-4-git-send-email-groeck@chromium.org>
References: <1470169975-19941-1-git-send-email-groeck@chromium.org>
	 <1470169975-19941-4-git-send-email-groeck@chromium.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
> +static bool svdm_consume_svids(struct tcpm_port *port, const u32
> *payload,
> +                              int cnt)
> +{
> +       struct pd_mode_data *pmdata = &port->mode_data;
> +       int i;
> +
> +       for (i = 1; i < cnt; i++) {
> +               u16 svid;
> +
> +               svid = (payload[i] >> 16) & 0xffff;
> +               if (!svid)
> +                       return false;

Hi,

this looks like an endianness bug.

	Regards
		Oliver