From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757072AbcHCOS0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Aug 2016 10:18:26 -0400
Received: from benson.default.arb33.uk0.bigv.io ([46.43.0.16]:34108 "EHLO
	benson.default.arb33.uk0.bigv.io" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755121AbcHCOSW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Aug 2016 10:18:22 -0400
X-Greylist: delayed 1931 seconds by postgrey-1.27 at vger.kernel.org; Wed, 03 Aug 2016 10:18:22 EDT
Message-ID: <1470231959.4745.11.camel@hellion.org.uk>
Subject: Re: [PATCH] ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from
 arch=arm
From: Ian Campbell <ijc@hellion.org.uk>
To: Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "arm@kernel.org" <arm@kernel.org>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Catalin Marinas <catalin.marinas@arm.com>, Lee Jones <lee@kernel.org>,
        Will Deacon <will.deacon@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Anholt <eric@anholt.net>, Gerd Hoffmann <kraxel@redhat.com>,
        Frank Rowand <frowand.list@gmail.com>,
        linux-rpi-kernel@lists.infradead.org
Date: Wed, 03 Aug 2016 14:45:59 +0100
In-Reply-To: <20160803133041.GA12499@leverpostej>
References: <1470213635-6934-1-git-send-email-ijc@hellion.org.uk>
	 <CAL_JsqKs+9UxKa=_PZWM-AO8b+MqbxypO_3h6ZGQtYjHcB1Drg@mail.gmail.com>
	 <20160803133041.GA12499@leverpostej>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.4-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-08-03 at 14:30 +0100, Mark Rutland wrote:
> On Wed, Aug 03, 2016 at 08:13:51AM -0500, Rob Herring wrote:
> > 
> > > > On Wed, Aug 3, 2016 at 3:40 AM, Ian Campbell <ijc@hellion.org.uk> wrote:
> > > 
> > > These includes in turn require a skeleton.dtsi to be present, so add one as
> > > a real file (with the same contents as arch/arm) rather than a symlink.
> > 
> > I don't follow why skeleton.dtsi is needed. The 32-bit RPi dts files
> > are including it?

Exactly.

> >  If so, can we just remove it. We decided
> > skeleton.dtsi was a bad idea.
> 
> Yup. I don't want to see skeleton.dtsi reappear, and the necessary
> fixups to source files are relatively simple.
> 
> Ian, see commit 3ebee5a2e141496b ("arm64: dts: kill skeleton.dtsi") for
> the rationale, and hints as to what needs to be fixed up (e.g. if empty
> > memory nodes are required, there should be a comment as to why).

Understood.

I can make the mechanical fix to arch/arm/boot/dts/bcm283x.dtsi (which
is linked here as arch/arm64/boot/dts/broadcom/bcm283x.dtsi which
causes the need for skeleton.dtsi) but I don't have any R-Pi hardware
with which to verify the need (or not) for empty memory nodes etc.

> Perhaps this is a good time to attack the remaining 32-bit skeleton.dtsi
> > users. I'll take another look come -rc1.

linux.git$ git grep skeleton.dtsi -- arch/arm  | wc -l
148
linux.git$

Good luck ;-)

Ian.