* [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const
@ 2016-08-05 6:40 Axel Lin
2016-08-05 13:58 ` Thor Thayer
2016-08-09 13:03 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-08-05 6:40 UTC (permalink / raw)
To: Lee Jones; +Cc: Thor Thayer, linux-kernel, Axel Lin
It's only used in this driver and never get modified, make it static const.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/altera-a10sr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
index c05aa4f..40ed65e 100644
--- a/drivers/mfd/altera-a10sr.c
+++ b/drivers/mfd/altera-a10sr.c
@@ -94,7 +94,7 @@ static bool altr_a10sr_reg_volatile(struct device *dev, unsigned int reg)
}
}
-const struct regmap_config altr_a10sr_regmap_config = {
+static const struct regmap_config altr_a10sr_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const
2016-08-05 6:40 [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const Axel Lin
@ 2016-08-05 13:58 ` Thor Thayer
2016-08-09 13:03 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Thor Thayer @ 2016-08-05 13:58 UTC (permalink / raw)
To: Axel Lin, Lee Jones; +Cc: linux-kernel
On 08/05/2016 01:40 AM, Axel Lin wrote:
> It's only used in this driver and never get modified, make it static const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/altera-a10sr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
> index c05aa4f..40ed65e 100644
> --- a/drivers/mfd/altera-a10sr.c
> +++ b/drivers/mfd/altera-a10sr.c
> @@ -94,7 +94,7 @@ static bool altr_a10sr_reg_volatile(struct device *dev, unsigned int reg)
> }
> }
>
> -const struct regmap_config altr_a10sr_regmap_config = {
> +static const struct regmap_config altr_a10sr_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
>
>
Reviewed-by: Thor Thayer <tthayer@opensource.altera.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const
2016-08-05 6:40 [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const Axel Lin
2016-08-05 13:58 ` Thor Thayer
@ 2016-08-09 13:03 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2016-08-09 13:03 UTC (permalink / raw)
To: Axel Lin; +Cc: Thor Thayer, linux-kernel
On Fri, 05 Aug 2016, Axel Lin wrote:
> It's only used in this driver and never get modified, make it static const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/altera-a10sr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
> index c05aa4f..40ed65e 100644
> --- a/drivers/mfd/altera-a10sr.c
> +++ b/drivers/mfd/altera-a10sr.c
> @@ -94,7 +94,7 @@ static bool altr_a10sr_reg_volatile(struct device *dev, unsigned int reg)
> }
> }
>
> -const struct regmap_config altr_a10sr_regmap_config = {
> +static const struct regmap_config altr_a10sr_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-09 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-05 6:40 [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const Axel Lin
2016-08-05 13:58 ` Thor Thayer
2016-08-09 13:03 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).