From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161067AbcHEJao (ORCPT ); Fri, 5 Aug 2016 05:30:44 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:37026 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759494AbcHEJak (ORCPT ); Fri, 5 Aug 2016 05:30:40 -0400 Message-ID: <1470389433.2977.31.camel@sipsolutions.net> Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool From: Johannes Berg To: Julia Lawall , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 05 Aug 2016 11:30:33 +0200 In-Reply-To: <1470387411-15879-9-git-send-email-Julia.Lawall@lip6.fr> (sfid-20160805_111640_944584_00A38E89) References: <1470387411-15879-1-git-send-email-Julia.Lawall@lip6.fr> <1470387411-15879-9-git-send-email-Julia.Lawall@lip6.fr> (sfid-20160805_111640_944584_00A38E89) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.2-2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - if (of_get_property(pdev->dev.of_node, > -     "little-endian", NULL)) > + if (of_property_read_bool(pdev->dev.of_node, "little- > endian")) >   priv->is_little_endian = true; >   else >   priv->is_little_endian = false; > Perhaps, while changing this, that'd be better as priv->is_little_endian = of_property_read_bool(...); Obviously that would've worked before, but now it'd be even easier to understand, it seems. johannes