From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161124AbcHEKbR (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Aug 2016 06:31:17 -0400
Received: from s3.sipsolutions.net ([5.9.151.49]:37286 "EHLO sipsolutions.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759486AbcHEKbO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Aug 2016 06:31:14 -0400
Message-ID: <1470391948.2977.33.camel@sipsolutions.net>
Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool
From: Johannes Berg <johannes@sipsolutions.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 05 Aug 2016 12:12:28 +0200
In-Reply-To: <alpine.DEB.2.10.1608051207510.2999@hadrien>
References: <1470387411-15879-1-git-send-email-Julia.Lawall@lip6.fr>
	  <1470387411-15879-9-git-send-email-Julia.Lawall@lip6.fr>
	  (sfid-20160805_111640_944584_00A38E89) <1470389433.2977.31.camel@sipsolutions.net>
	 <alpine.DEB.2.10.1608051207510.2999@hadrien>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.2-2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
> 
> Can I do the same for:
> 
>         if (of_property_read_bool(np, "phy-clk-valid"))
>                 pdata->check_phy_clk_valid = 1;
>         else
>                 pdata->check_phy_clk_valid = 0;
> 
> The type is not bool, but:
> 
> include/linux/fsl_devices.h:    unsigned        check_phy_clk_valid:1;
> 
The type doesn't even matter, does it? Any bool->int conversion should
result in 0/1.

johannes