From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759684AbcHEMYo (ORCPT ); Fri, 5 Aug 2016 08:24:44 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:37724 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759654AbcHEMYn (ORCPT ); Fri, 5 Aug 2016 08:24:43 -0400 Message-ID: <1470399880.2977.41.camel@sipsolutions.net> Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput From: Johannes Berg To: Maxim Altshul , linux-kernel@vger.kernel.org Cc: john.stultz@linaro.org, Kalle Valo , Eliad Peller , Yaniv Machani Date: Fri, 05 Aug 2016 14:24:40 +0200 In-Reply-To: <1470399762.2977.40.camel@sipsolutions.net> References: <20160804124314.7636-1-maxim.altshul@ti.com> <20160804124314.7636-2-maxim.altshul@ti.com> <1470399762.2977.40.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.2-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-08-05 at 14:22 +0200, Johannes Berg wrote: > On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote: > > - The variable is added to allow the driver an easy access > > to it's own hw->priv when the op is invoked. > > > > - Change wlcore op accordingly. > > > I'm applying this now, with a big BUT: > > 1) your changelog is crap - I've rewritten it to indicate what's > going > on > > 2) I think the change makes sense, but as far as fixing the bug is > concerned it's actually completely stupid > > 3) I expect you to submit a proper bugfix for mac80211 ASAP, to not > call into the driver before the station is actually known to the > driver. 4) please indent your code properly when submitting... johannes