From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759960AbcHEPe0 (ORCPT ); Fri, 5 Aug 2016 11:34:26 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:38622 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161523AbcHEPeZ (ORCPT ); Fri, 5 Aug 2016 11:34:25 -0400 Message-ID: <1470411261.2977.43.camel@sipsolutions.net> Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput From: Johannes Berg To: "Altshul, Maxim" , "linux-kernel@vger.kernel.org" Cc: "john.stultz@linaro.org" , Kalle Valo , Eliad Peller , "Machani, Yaniv" Date: Fri, 05 Aug 2016 17:34:21 +0200 In-Reply-To: References: <20160804124314.7636-1-maxim.altshul@ti.com> <20160804124314.7636-2-maxim.altshul@ti.com> <1470399762.2977.40.camel@sipsolutions.net> ,<1470399880.2977.41.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.2-2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-08-05 at 13:25 +0000, Altshul, Maxim wrote: > Hi, > 1) Sorry about the change log, I will try to be clearer next time. Just mention something about how the bug happens please, at least. > 2+3) The issue is not that the station is not known, it's that > wl_sta->wl was null.  > wl member is now completely removed from wl_sta (PATCH 2/2) and hw is > sent directly from mac80211 to the driver (so it can get hw->priv). Right, I understand that wl_sta->wl was NULL. But the driver must have some code to assign wl_sta->wl, right? And that would be called in add_sta or sta_state. Thus the reason for the crash would be that the station wasn't actually known to the driver yet. Even if that wasn't quite the reason here, I think we need to take it into account and check sta->uploaded before calling the driver, so I'd like you to submit a patch for that. johannes