From: Leo Yan <leo.yan@linaro.org>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-kernel@vger.kernel.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v2] sched/fair: refine maximum periods for decay_load
Date: Fri, 5 Aug 2016 23:40:59 +0800 [thread overview]
Message-ID: <1470411659-28584-1-git-send-email-leo.yan@linaro.org> (raw)
In current code, decay_load() will consider to set load value to zero
after passing 32*64 ms. So this means max_load * (0.5^64) ~= 0.
Kernel can support maximum number of processes and threads to 2^29 and
set task with highest priority with nice=-20 (weight = 88761). So in
worst case, one CPU may have maximum load value is:
max_load = 2^29 * 88761 < 2^46
In theory after pass 46 periods we can ensure load value to be decayed
to zero. So this patch is to change maximum periods from 64 to 46.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
kernel/sched/fair.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e342159..bbd01eb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2622,7 +2622,15 @@ static __always_inline u64 decay_load(u64 val, u64 n)
if (!n)
return val;
- else if (unlikely(n > LOAD_AVG_PERIOD * 63))
+ /*
+ * Kernel can support maximum number of processes and threads up to
+ * 2^29 and task has highest weight 88761 with nice=-20.
+ *
+ * maximum load = 2^29 * 88761 < 2^46
+ *
+ * So pass 46 periods can ensure maximum load to be decayed to zero.
+ */
+ else if (unlikely(n >= LOAD_AVG_PERIOD * 46))
return 0;
/* after bounds checking we can collapse to 32-bit */
--
1.9.1
reply other threads:[~2016-08-05 15:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470411659-28584-1-git-send-email-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).