From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948027AbcHEVJ6 (ORCPT ); Fri, 5 Aug 2016 17:09:58 -0400 Received: from host.buserror.net ([209.198.135.123]:58814 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S3000301AbcHEVJu (ORCPT ); Fri, 5 Aug 2016 17:09:50 -0400 Message-ID: <1470431358.25630.249.camel@buserror.net> From: Scott Wood To: york sun , Michael Ellerman , "linux-edac@vger.kernel.org" Cc: "morbidrsa@gmail.com" , Stuart Yoder , "bp@alien8.de" , Benjamin Herrenschmidt , Paul Mackerras , Kevin Hao , Andrew Donnellan , Yinghai Lu , Bjorn Helgaas , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Date: Fri, 05 Aug 2016 16:09:18 -0500 In-Reply-To: References: <1470351518-22404-1-git-send-email-york.sun@nxp.com> <1470351518-22404-2-git-send-email-york.sun@nxp.com> <877fbvkhi3.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 75.72.173.242 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-08-05 at 20:29 +0000, york sun wrote: > On 08/04/2016 08:43 PM, Michael Ellerman wrote: > > > > Does the driver really need to use these routines? They're meant for use > > early in boot, before PCI is setup. > > > > AFAICS this is just a regular driver, so when it's probed the PCI > > devices should have already been scanned. In which case pci_get_device() > > could work couldn't it? (I see other edac drivers doing that). > I am trying to fix this but need some help. We are dealing with PCIe  > controller here. Does it have a bus number assigned at this point? If  > yes, how can I find it? I seem not able to find out where the  > platform_data is filled as well. Can someone kindly point it out to me? The platform data comes from add_err_dev() in arch/powerpc/sysdev/fsl_pci.c. -Scott