From: Lyude <cpaul@redhat.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
xorg-driver-ati@lists.freedesktop.org
Cc: Lyude <cpaul@redhat.com>, "David Airlie" <airlied@linux.ie>,
linux-kernel@vger.kernel.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Tom St Denis" <tom.stdenis@amd.com>,
"Jammy Zhou" <Jammy.Zhou@amd.com>,
"Ken Wang" <Qingqing.Wang@amd.com>
Subject: [PATCH 0/7] Minor DP aux transaction fixes
Date: Fri, 5 Aug 2016 20:30:32 -0400 [thread overview]
Message-ID: <1470443443-27252-1-git-send-email-cpaul@redhat.com> (raw)
While I was investigating an unrelated bug on the radeon driver, I noticed that
it's become rather difficult to actually read through dmesg with drm.debug
turned on, on account of the huge number of messages we end up printing from
failed DP aux transactions that happen every time we reprobe each connector.
Timed out transactions are relatively normal, and as well there's a lot of
places in radeon/amdgpu where we're printing redundant debugging information
dozens of times each time we attempt a DP aux transactions.
Additionally, I've removed some of the retry loops in amdgpu/radeon. These were
definitely useful at one point, but since we now retry any failed aux
transaction unconditionally in DRM's dp helpers they don't serve much purpose
other then to make failing aux transactions take a lot more time then they need
to.
Lyude (7):
drm/dp_helper: Print first error received on failure in
drm_dp_dpcd_access()
drm/radeon: Don't print error on aux transaction timeouts
drm/radeon: Don't retry 7 times in radeon_dp_dpcd()
drm/amdgpu: Don't print error on aux transaction timeouts
drm/amdgpu: Don't retry 7 times in amdgpu_atombios_dp_get_dpcd()
drm: Add ratelimited versions of the DRM_DEBUG* macros
drm/dp_helper: Rate limit timeout errors from drm_dp_i2c_do_msg()
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 22 ++++++++++------------
drivers/gpu/drm/drm_dp_helper.c | 14 ++++++++++++--
drivers/gpu/drm/radeon/atombios_dp.c | 21 ++++++++++-----------
drivers/gpu/drm/radeon/radeon_dp_auxch.c | 1 -
include/drm/drmP.h | 30 ++++++++++++++++++++++++++++++
5 files changed, 62 insertions(+), 26 deletions(-)
--
2.7.4
next reply other threads:[~2016-08-06 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 0:30 Lyude [this message]
2016-08-06 0:30 ` [PATCH 1/7] drm/dp_helper: Print first error received on failure in drm_dp_dpcd_access() Lyude
2016-08-06 0:30 ` [PATCH 2/7] drm/radeon: Don't print error on aux transaction timeouts Lyude
2016-08-06 0:30 ` [PATCH 3/7] drm/radeon: Don't retry 7 times in radeon_dp_dpcd() Lyude
2016-08-06 0:30 ` [PATCH 4/7] drm/amdgpu: Don't print error on aux transaction timeouts Lyude
2016-08-06 0:30 ` [PATCH 5/7] drm/amdgpu: Don't retry 7 times in amdgpu_atombios_dp_get_dpcd() Lyude
2016-08-06 0:30 ` [PATCH 6/7] drm: Add ratelimited versions of the DRM_DEBUG* macros Lyude
2016-08-06 20:32 ` Joe Perches
2016-08-06 0:30 ` [PATCH 7/7] drm/dp_helper: Rate limit timeout errors from drm_dp_i2c_do_msg() Lyude
2016-08-06 10:22 ` [PATCH 0/7] Minor DP aux transaction fixes Christian König
2016-08-08 17:30 ` Alex Deucher
2016-08-09 6:11 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470443443-27252-1-git-send-email-cpaul@redhat.com \
--to=cpaul@redhat.com \
--cc=Jammy.Zhou@amd.com \
--cc=Qingqing.Wang@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.stdenis@amd.com \
--cc=xorg-driver-ati@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).