From: Lyude <cpaul@redhat.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
xorg-driver-ati@lists.freedesktop.org
Cc: Lyude <cpaul@redhat.com>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/7] drm/dp_helper: Print first error received on failure in drm_dp_dpcd_access()
Date: Fri, 5 Aug 2016 20:30:33 -0400 [thread overview]
Message-ID: <1470443443-27252-2-git-send-email-cpaul@redhat.com> (raw)
In-Reply-To: <1470443443-27252-1-git-send-email-cpaul@redhat.com>
Since we always retry in drm_dp_dpcd_access() regardless of the error,
we're going to make a lot of noise if the aux->transfer function prints
it's own errors (as is the case with radeon). If we can print the error
code here, this reduces the need for drivers to do this. So instead of
having to print "dp_aux_ch timed out" over 32 times we can just print
once.
Signed-off-by: Lyude <cpaul@redhat.com>
---
drivers/gpu/drm/drm_dp_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 8f11b87..43be189 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -223,7 +223,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
err = ret;
}
- DRM_DEBUG_KMS("too many retries, giving up\n");
+ DRM_DEBUG_KMS("Too many retries, giving up. First error: %d\n", err);
ret = err;
unlock:
--
2.7.4
next prev parent reply other threads:[~2016-08-06 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 0:30 [PATCH 0/7] Minor DP aux transaction fixes Lyude
2016-08-06 0:30 ` Lyude [this message]
2016-08-06 0:30 ` [PATCH 2/7] drm/radeon: Don't print error on aux transaction timeouts Lyude
2016-08-06 0:30 ` [PATCH 3/7] drm/radeon: Don't retry 7 times in radeon_dp_dpcd() Lyude
2016-08-06 0:30 ` [PATCH 4/7] drm/amdgpu: Don't print error on aux transaction timeouts Lyude
2016-08-06 0:30 ` [PATCH 5/7] drm/amdgpu: Don't retry 7 times in amdgpu_atombios_dp_get_dpcd() Lyude
2016-08-06 0:30 ` [PATCH 6/7] drm: Add ratelimited versions of the DRM_DEBUG* macros Lyude
2016-08-06 20:32 ` Joe Perches
2016-08-06 0:30 ` [PATCH 7/7] drm/dp_helper: Rate limit timeout errors from drm_dp_i2c_do_msg() Lyude
2016-08-06 10:22 ` [PATCH 0/7] Minor DP aux transaction fixes Christian König
2016-08-08 17:30 ` Alex Deucher
2016-08-09 6:11 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470443443-27252-2-git-send-email-cpaul@redhat.com \
--to=cpaul@redhat.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xorg-driver-ati@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).