From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751664AbcHGDNN (ORCPT ); Sat, 6 Aug 2016 23:13:13 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34002 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbcHGDNL (ORCPT ); Sat, 6 Aug 2016 23:13:11 -0400 From: David Carrillo-Cisneros To: linux-kernel@vger.kernel.org Cc: "x86@kernel.org" , Ingo Molnar , Thomas Gleixner , Andi Kleen , Kan Liang , Peter Zijlstra , Vegard Nossum , Paul Turner , Stephane Eranian , David Carrillo-Cisneros Subject: [PATCH v2 1/4] perf/core: check return value of perf_event_read IPI Date: Sat, 6 Aug 2016 20:12:54 -0700 Message-Id: <1470539577-102094-2-git-send-email-davidcc@google.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1470539577-102094-1-git-send-email-davidcc@google.com> References: <1470539577-102094-1-git-send-email-davidcc@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The call to smp_call_function_single in perf_event_read() may fail and, when it does, its error value is the one to return. Signed-off-by: David Carrillo-Cisneros Reviewed-by: Stephane Eranian --- kernel/events/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 9345028..96523fd 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -3469,9 +3469,9 @@ static int perf_event_read(struct perf_event *event, bool group) .group = group, .ret = 0, }; - smp_call_function_single(event->oncpu, - __perf_event_read, &data, 1); - ret = data.ret; + ret = smp_call_function_single(event->oncpu, + __perf_event_read, &data, 1); + ret = ret ? : data.ret; } else if (event->state == PERF_EVENT_STATE_INACTIVE) { struct perf_event_context *ctx = event->ctx; unsigned long flags; -- 2.8.0.rc3.226.g39d4020