From: Oliver Neukum <oneukum@suse.com>
To: Robert Foss <robert.foss@collabora.com>
Cc: Ben Chan <benchan@chromium.org>,
pprabhu@chromium.org, Guenter Roeck <groeck@google.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error
Date: Sun, 07 Aug 2016 10:59:20 +0200 [thread overview]
Message-ID: <1470560360.2014.1.camel@suse.com> (raw)
In-Reply-To: <1775d53f-0129-4e94-b08c-7d4c58fa9fa6@collabora.com>
On Thu, 2016-08-04 at 13:44 -0400, Robert Foss wrote:
>
> On 2016-08-03 06:39 AM, Oliver Neukum wrote:
> > On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote:
> > How can that depend on what we return to user space?
> > In the driver we can continue just ignoring errors.
> > Now, if user space stops reading because we reported an error,
> > that is the decision user space has made. We cannot ignore errors
> > in the kernel because we don't like what user space does when it
> > sees the error.
>
> So perhaps the better solution is to be more intelligent about how
> desc->rerr is written to during after an error to be able to maintain
> the error condition?
Yes, good idea. I think an error condition should never be overwritten.
So we go to the current behaviour only if a second error before
user space has seen the3 first error arises. Would that fix your
issue?
Regards
Oliver
next prev parent reply other threads:[~2016-08-07 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 18:19 [PACTH v1] cdc-wdm: Clear read pipeline in case of error robert.foss
2016-08-02 12:23 ` Oliver Neukum
2016-08-02 13:54 ` Robert Foss
2016-08-02 13:59 ` Oliver Neukum
2016-08-02 14:37 ` Robert Foss
2016-08-03 10:39 ` Oliver Neukum
2016-08-04 17:44 ` Robert Foss
2016-08-07 8:59 ` Oliver Neukum [this message]
2016-08-08 14:38 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470560360.2014.1.camel@suse.com \
--to=oneukum@suse.com \
--cc=benchan@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pprabhu@chromium.org \
--cc=robert.foss@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).