From: Laura Abbott <labbott@redhat.com>
To: "Sumit Semwal" <sumit.semwal@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>
Cc: Laura Abbott <labbott@redhat.com>,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org,
Android Kernel Team <kernel-team@android.com>
Subject: [RESEND][PATCH 1/5] staging: android: ion: Get rid of ion_sg_table
Date: Mon, 8 Aug 2016 09:52:54 -0700 [thread overview]
Message-ID: <1470675178-13052-2-git-send-email-labbott@redhat.com> (raw)
In-Reply-To: <1470675178-13052-1-git-send-email-labbott@redhat.com>
The ion_sg_table interface is mostly a reimplementation of
what dma_buf is doing. Clients should be using dma_buf APIs instead.
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
drivers/staging/android/ion/ion.c | 20 --------------------
drivers/staging/android/ion/ion.h | 11 -----------
2 files changed, 31 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index a2cf93b..95b18ac 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -917,26 +917,6 @@ void ion_client_destroy(struct ion_client *client)
}
EXPORT_SYMBOL(ion_client_destroy);
-struct sg_table *ion_sg_table(struct ion_client *client,
- struct ion_handle *handle)
-{
- struct ion_buffer *buffer;
- struct sg_table *table;
-
- mutex_lock(&client->lock);
- if (!ion_handle_validate(client, handle)) {
- pr_err("%s: invalid handle passed to map_dma.\n",
- __func__);
- mutex_unlock(&client->lock);
- return ERR_PTR(-EINVAL);
- }
- buffer = handle->buffer;
- table = buffer->sg_table;
- mutex_unlock(&client->lock);
- return table;
-}
-EXPORT_SYMBOL(ion_sg_table);
-
static void ion_buffer_sync_for_device(struct ion_buffer *buffer,
struct device *dev,
enum dma_data_direction direction);
diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
index a1331fc..225c34a 100644
--- a/drivers/staging/android/ion/ion.h
+++ b/drivers/staging/android/ion/ion.h
@@ -149,17 +149,6 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
ion_phys_addr_t *addr, size_t *len);
/**
- * ion_map_dma - return an sg_table describing a handle
- * @client: the client
- * @handle: the handle
- *
- * This function returns the sg_table describing
- * a particular ion handle.
- */
-struct sg_table *ion_sg_table(struct ion_client *client,
- struct ion_handle *handle);
-
-/**
* ion_map_kernel - create mapping for the given handle
* @client: the client
* @handle: handle to map
--
2.5.5
next prev parent reply other threads:[~2016-08-08 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 16:52 [RESEND][PATCH 0/5] Ion cleanup Laura Abbott
2016-08-08 16:52 ` Laura Abbott [this message]
2016-08-08 16:52 ` [RESEND][PATCH 2/5] staging: android: ion: Drop ion_phys interface Laura Abbott
2016-08-08 16:52 ` [RESEND][PATCH 3/5] staging: android: ion: Get rid of map_dma/unmap_dma Laura Abbott
2016-08-08 16:52 ` [RESEND][PATCH 4/5] staging: android: ion: Drop ion_carveout_allocate definitions Laura Abbott
2016-08-08 16:52 ` [RESEND][PATCH 5/5] staging: android: ion: Get rid of ion_reserve Laura Abbott
2016-08-14 8:47 ` [Linaro-mm-sig] [RESEND][PATCH 0/5] Ion cleanup Benjamin Gaignard
2016-08-15 15:08 ` Sumit Semwal
2016-08-15 14:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470675178-13052-2-git-send-email-labbott@redhat.com \
--to=labbott@redhat.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox