Re: [PATCH 2/2] device-tree: nexus7: Add IMEM syscon and reboot reason support

John Stultz
2016-08-10T18:28:49Z

On Tue, Aug 9, 2016 at 9:28 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> On Mon 08 Aug 15:34 PDT 2016, John Stultz wrote:
>
>> This patch add the IMEM syscon memory region to the DT,
>> as well as addds support for the magic reboot reason
>> values that are written to the address for each mode.
>>
>
> This looks good, double checked the addresses and magics. But I think
> you should move the entire thing to qcom-apq8064.dtsi, as this is common
> to the base platform.

Interesting, so do all 8064's use the same bootloader?

> And I would prefer if you updated the subject prefix...
>
> With the move and subject update:
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

thanks!
-john