Re: [PATCH 2/2] device-tree: nexus7: Add IMEM syscon and reboot reason support

Bjorn Andersson
2016-08-10T19:50:11Z

On Tue 09 Aug 22:04 PDT 2016, John Stultz wrote:

> On Tue, Aug 9, 2016 at 9:28 PM, Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> > On Mon 08 Aug 15:34 PDT 2016, John Stultz wrote:
> >
> >> This patch add the IMEM syscon memory region to the DT,
> >> as well as addds support for the magic reboot reason
> >> values that are written to the address for each mode.
> >>
> >
> > This looks good, double checked the addresses and magics. But I think
> > you should move the entire thing to qcom-apq8064.dtsi, as this is common
> > to the base platform.
>
> Interesting, so do all 8064's use the same bootloader?
>

As far as I can tell, the APQ8064 comes with 4kb of IMEM, so that part
is common regardless.

There is no indication of the restart reason being "optional" in the
downstream kernel, but that's not necessarily a "yes" to your question.

So, please move it to the apq8064.dtsi, as there are no indications of
systems not having this setup. Worst case would be that I'm wrong and we
have to move it out to all current targets sometime in the future.

Regards,
Bjorn