From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932597AbcHIXL5 (ORCPT ); Tue, 9 Aug 2016 19:11:57 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:23849 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932540AbcHIXLx convert rfc822-to-8bit (ORCPT ); Tue, 9 Aug 2016 19:11:53 -0400 Message-ID: <1470720897.23538.2.camel@oracle.com> Subject: [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking From: Lidza Louina To: Greg Kroah-Hartman , Ivan Safonov , Kyle Kuffermann , Sandhya Bankar , Geliang Tang , Bryan Paul , Bhaktipriya Shridhar , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 09 Aug 2016 01:34:57 -0400 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it. The code had an up() where a down() should've been. This patch fixes that. Signed-off-by: Lidza Louina ---  drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c index 7748523..16f0b19 100644 --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c @@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)   allow_signal(SIGTERM);     pcmdpriv->cmdthd_running = true; - up(&pcmdpriv->terminate_cmdthread_sema); + down(&pcmdpriv->terminate_cmdthread_sema);     RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));   --  2.7.4