* [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking
@ 2016-08-09 5:34 Lidza Louina
2016-08-21 16:18 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Lidza Louina @ 2016-08-09 5:34 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ivan Safonov, Kyle Kuffermann, Sandhya Bankar,
Geliang Tang, Bryan Paul, Bhaktipriya Shridhar, devel,
linux-kernel
The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
The code had an up() where a down() should've been. This patch fixes that.
Signed-off-by: Lidza Louina <Lidza.Louina@oracle.com>
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 7748523..16f0b19 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)
allow_signal(SIGTERM);
pcmdpriv->cmdthd_running = true;
- up(&pcmdpriv->terminate_cmdthread_sema);
+ down(&pcmdpriv->terminate_cmdthread_sema);
RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking
2016-08-09 5:34 [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking Lidza Louina
@ 2016-08-21 16:18 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2016-08-21 16:18 UTC (permalink / raw)
To: Lidza Louina
Cc: Ivan Safonov, Kyle Kuffermann, Sandhya Bankar, Geliang Tang,
Bryan Paul, Bhaktipriya Shridhar, devel, linux-kernel
On Tue, Aug 09, 2016 at 01:34:57AM -0400, Lidza Louina wrote:
> The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
> The code had an up() where a down() should've been. This patch fixes that.
>
> Signed-off-by: Lidza Louina <Lidza.Louina@oracle.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> index 7748523..16f0b19 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> @@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)
> allow_signal(SIGTERM);
>
> pcmdpriv->cmdthd_running = true;
> - up(&pcmdpriv->terminate_cmdthread_sema);
> + down(&pcmdpriv->terminate_cmdthread_sema);
>
> RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));
>
> --
> 2.7.4
This path is corrupted somehow and doesn't apply at all :(
Can you see what went wrong with your email client and try again?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-21 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-09 5:34 [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking Lidza Louina
2016-08-21 16:18 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox